Skip to content

docs(pegboard-runner): explain alloc idx eviction invariant #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanFlurry wants to merge 1 commit into from
Closed

docs(pegboard-runner): explain alloc idx eviction invariant #4626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions engine/packages/pegboard-runner/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ impl CustomServeTrait for PegboardRunnerWsCustomServe {
}
// Clear alloc idx if not evicted
else {
// Eviction implies the replacement connection reused the same runner_id and already
// rewrote the alloc idx, so clearing here would race the new connection.
// Make runner immediately ineligible when it disconnects
let update_alloc_res = self
.ctx
Expand Down
Loading