Skip to content

fix(guard): serialize gateway actor keys correctly #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NathanFlurry wants to merge 1 commit into
base: break-up/subscribe-before-namespace-dispatch
Choose a base branch
from
+6 −3
Draft

fix(guard): serialize gateway actor keys correctly #4655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions engine/packages/guard/src/routing/pegboard_gateway/resolve_actor_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ async fn resolve_query_target_dc_label(

fn serialize_actor_key(key: &[String]) -> Result<String> {
const EMPTY_KEY: &str = "/";
const KEY_SEPARATOR: char = '/';
const KEY_SEPARATOR: &str = "/";
const KEY_SEPARATOR_CHAR: char = '/';

if key.is_empty() {
return Ok(EMPTY_KEY.to_string());
Expand All @@ -221,11 +222,13 @@ fn serialize_actor_key(key: &[String]) -> Result<String> {
continue;
}

let escaped = part.replace('\\', "\\\\").replace(KEY_SEPARATOR, "\\/");
let escaped = part
.replace('\\', "\\\\")
.replace(KEY_SEPARATOR_CHAR, "\\/");
escaped_parts.push(escaped);
}

Ok(escaped_parts.join(EMPTY_KEY))
Ok(escaped_parts.join(KEY_SEPARATOR))
}

fn is_duplicate_key_error(err: &anyhow::Error) -> bool {
Expand Down
Loading