fix(rivetkit): update config to match envoys & remove manager references#4663
fix(rivetkit): update config to match envoys & remove manager references#4663NathanFlurry wants to merge 1 commit into04-14-chore_publish_pin_docker_base_image_refsfrom
Conversation
|
🚅 Deployed to the rivet-pr-4663 environment in rivet-frontend
|
PR Review: fix(rivetkit): update config to match envoys & remove manager referencesOverviewThis PR performs a significant API cleanup, renaming "manager" terminology to more generic HTTP server concepts, restructuring engine-related config out of the nested Config API Renames (Breaking Changes)The following public API fields are renamed (Old -> New):
The PR description checklist is entirely unchecked and does not mention a migration guide. If any of these fields are in published documentation or stable user-facing APIs, a brief deprecation note or CHANGELOG entry would be helpful. Specific Issues1. Port default change: 6420 to 6421 Both docs pages still display port 6420 in example URLs after this change:
If 6420 is now the engine port and 6421 is the RivetKit HTTP port, the docs should be clarified. If clients connect directly to the engine at 6420, the URLs are correct but the variable name change to 2. In 3. Hardcoded deprecated fields still sent to engine In 4. SQL injection in test fixture (pre-existing) In Positive Changes
Minor Notes
SummaryThe API restructuring is coherent and the naming improvements are good. The main items to verify before merging:
|
5835291 to
76b2ccd
Compare
76b2ccd to
3d11847
Compare
3d11847 to
c43281b
Compare
c43281b to
2e8cb57
Compare
2e8cb57 to
50b79ec
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4663All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-046f5f1
docker pull rivetdev/engine:full-046f5f1Individual packagesnpm install rivetkit@pr-4663
npm install @rivetkit/react@pr-4663
npm install @rivetkit/rivetkit-native@pr-4663
npm install @rivetkit/workflow-engine@pr-4663 |
50b79ec to
59adb46
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: