Skip to content

test(rivetkit): tag sleep routing workarounds#4665

Closed
NathanFlurry wants to merge 1 commit intobreak-up/stabilize-driver-lifecycle-testsfrom
break-up/annotate-sleep-routing-todos
Closed

test(rivetkit): tag sleep routing workarounds#4665
NathanFlurry wants to merge 1 commit intobreak-up/stabilize-driver-lifecycle-testsfrom
break-up/annotate-sleep-routing-todos

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry marked this pull request as ready for review April 15, 2026 03:09
@claude
Copy link
Copy Markdown

claude bot commented Apr 15, 2026

Code Review

Overview

This PR tags all existing sleep/wake timing workarounds in the driver test suite with TODO(RVT-6193) comments, making them traceable to a single ticket. It also converts one HACK: comment into the standard TODO format. No functional code changes -- pure documentation cleanup.

What is Good

  • Consistent tracking: All 9 workaround sites now reference RVT-6193, making it easy to find and remove them all once the underlying routing fix lands.
  • Module-level context: Adding the TODO above function declarations is helpful -- a reader landing in the file gets the why before encountering the individual wait calls.
  • Comment style matches conventions: Complete sentences, no em dashes, no fragmented structures. Follows CLAUDE.md comment guidelines correctly.
  • HACK converted to TODO in actor-sleep.ts is a direct improvement -- the old label was opaque.

Minor Suggestions

  • The module-level comments say "several tests below use fixed waitFor windows". Being specific about the count would make it easier to verify completeness when cleaning up, though "several" is fine given the count could change.
  • Consider whether the module-level TODO should sit above the function it precedes vs. at the top of the file. For actor-sleep-db.ts and others where it sits above the exported test function, a top-of-file placement might be slightly more discoverable.

No Issues Found

No correctness, performance, or security concerns -- this is a comment-only change with no risk surface. Test behavior is unchanged.

This PR is straightforward and ready to merge once it comes out of draft. The TODO tagging is the right move before implementing the actual routing fix in RVT-6193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant