test(rivetkit): tag sleep routing workarounds#4665
Closed
NathanFlurry wants to merge 1 commit intobreak-up/stabilize-driver-lifecycle-testsfrom
Closed
test(rivetkit): tag sleep routing workarounds#4665NathanFlurry wants to merge 1 commit intobreak-up/stabilize-driver-lifecycle-testsfrom
NathanFlurry wants to merge 1 commit intobreak-up/stabilize-driver-lifecycle-testsfrom
Conversation
This was referenced Apr 15, 2026
Member
Author
11 tasks
|
Code Review Overview This PR tags all existing sleep/wake timing workarounds in the driver test suite with TODO(RVT-6193) comments, making them traceable to a single ticket. It also converts one HACK: comment into the standard TODO format. No functional code changes -- pure documentation cleanup. What is Good
Minor Suggestions
No Issues Found No correctness, performance, or security concerns -- this is a comment-only change with no risk surface. Test behavior is unchanged. This PR is straightforward and ready to merge once it comes out of draft. The TODO tagging is the right move before implementing the actual routing fix in RVT-6193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: