Skip to content

fix: enhance InfoBoxLng() to replace non dark-mode aware MessageBoxEx #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hpwamr merged 2 commits into from
Mar 6, 2026
Merged

fix: enhance InfoBoxLng() to replace non dark-mode aware MessageBoxEx #5575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b0115
fix: enhance InfoBoxLng() to replace non dark-mode aware MessageBoxEx…
RaiKoHoff Mar 6, 2026
15b4a29
Merge remote-tracking branch 'upstream/master' into Dev_Master
RaiKoHoff Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Config/Config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,13 @@ HANDLE AcquireWriteFileLock(LPCWSTR lpIniFilePath, OVERLAPPED& rOvrLpd)
if (!bLocked) {
HSTRINGW msg = StrgCreate(NULL);
StrgFormat(msg, L"AcquireWriteFileLock(%s): NO EXCLUSIVE LOCK ACQUIRED!", lpIniFilePath);
MsgBoxLastError(StrgGet(msg), 0);
InfoBoxLastError(StrgGet(msg), 0);
StrgDestroy(msg);
}
} else {
HSTRINGW msg = StrgCreate(NULL);
StrgFormat(msg, L"AcquireWriteFileLock(%s): INVALID FILE HANDLE!", lpIniFilePath);
MsgBoxLastError(StrgGet(msg), 0);
InfoBoxLastError(StrgGet(msg), 0);
StrgDestroy(msg);
}
return (bLocked ? hFile : INVALID_HANDLE_VALUE);
Expand All @@ -226,13 +226,13 @@ HANDLE AcquireReadFileLock(LPCWSTR lpIniFilePath, OVERLAPPED& rOvrLpd)
if (!bLocked) {
HSTRINGW msg = StrgCreate(NULL);
StrgFormat(msg, L"AcquireReadFileLock(%s): NO READER LOCK ACQUIRED!", lpIniFilePath);
MsgBoxLastError(StrgGet(msg), 0);
InfoBoxLastError(StrgGet(msg), 0);
StrgDestroy(msg);
}
} else {
HSTRINGW msg = StrgCreate(NULL);
StrgFormat(msg, L"AcquireReadFileLock(%s): INVALID FILE HANDLE!", lpIniFilePath);
MsgBoxLastError(StrgGet(msg), 0);
InfoBoxLastError(StrgGet(msg), 0);
StrgDestroy(msg);
}
return (bLocked ? hFile : INVALID_HANDLE_VALUE);
Expand Down Expand Up @@ -1138,11 +1138,11 @@ extern "C" bool CreateIniFile(const HPATHL hini_pth, DWORD* pdwFileSize_out)
if (IS_VALID_HANDLE(hFile)) {
CloseHandle(hFile); // done
} else {
WCHAR fileName[MAX_PATH_EXPLICIT>>1] = { L'\0' };
WCHAR fileName[MAX_PATH_EXPLICIT] = { L'\0' };
Path_GetDisplayName(fileName, COUNTOF(fileName), hini_pth, NULL, true);
HSTRINGW msg = StrgCreate(NULL);
StrgFormat(msg, L"CreateIniFile(%s): FAILED TO CREATE INITIAL INI FILE!", fileName);
MsgBoxLastError(StrgGet(msg), 0);
InfoBoxLastError(StrgGet(msg), 0);
StrgDestroy(msg);
if (pdwFileSize_out) { *pdwFileSize_out = 0UL; }
return false;
Expand All @@ -1157,11 +1157,11 @@ extern "C" bool CreateIniFile(const HPATHL hini_pth, DWORD* pdwFileSize_out)
dwFileSize = GetFileSize(hFile, &dwFSHigh);
CloseHandle(hFile);
} else {
WCHAR fileName[MAX_PATH_EXPLICIT>>1] = { L'\0' };
WCHAR fileName[MAX_PATH_EXPLICIT] = { L'\0' };
Path_GetDisplayName(fileName, COUNTOF(fileName), hini_pth, NULL, true);
HSTRINGW msg = StrgCreate(NULL);
StrgFormat(msg, L"CreateIniFile(%s): FAILED TO READ FILESIZE!", fileName);
MsgBoxLastError(StrgGet(msg), 0);
InfoBoxLastError(StrgGet(msg), 0);
StrgDestroy(msg);
dwFileSize = INVALID_FILE_SIZE;
}
Expand Down
Loading