Open
Conversation
stnichol
requested review from
RyanMatthewJacobs,
brandonpaiz,
rkrishn7 and
zzulanas
| return ( | ||
| bounds.top >= 0 && | ||
| // using a magic number of 130 | ||
| bounds.bottom <= (window.innerHeight || document.documentElement.clientHeight) - 130 |
Collaborator
There was a problem hiding this comment.
NIT: could you put parenthesis around each conditional statement
Collaborator
Author
There was a problem hiding this comment.
Yeah no prob, like this?
(bounds.top >= 0) &&
(bounds.bottom <= (window.innerHeight || document.documentElement.clientHeight) - 130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Summary
There is an additional check for auto-scrolling when a new message arrives in chat to see if the user is looking at a previous message. The windows double-scrollbar should be fixed as well (not sure how it looks on mac).
🔍 What's the new behavior?
The chat box will now only auto-scroll to the bottom if the user is at the bottom of the chat box.
🏷 Task Link
https://www.notion.so/Task-update-chat-functionality-for-easier-UI-for-user-f67527b9accc42aabd8fa3eaa619ea1b
↩️ Depends On
Link any other PRs here.
🧪 QA
Send messages in the chat until it overflows then scroll up to a previous message to see if sending a message auto-scrolls.
Also, open chat and send messages until it overflows on Mac to see if the scrollbar looks alright.
🛑 Risk Analysis