Remove MapboxV10 constant and dead code#4166
Merged
Conversation
MapboxV10 was always hardcoded to true on both platforms. Remove the constant and all conditional branches that checked it, simplifying the codebase. Closes #4131.
The constant actually means "v10 or later" and is always true. Keep it for backwards compatibility but mark as deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapboxV10 was always hardcoded to
trueon both iOS and Android (it really means "v10 or later"). This removes all internal dead code branches that checked it. The exported constant itself is kept for backwards compatibility but marked as deprecated.Closes #4131