Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and optimizations across the codebase, focusing on performance, stricter type handling, and updated dependencies. The most significant changes include enhanced benchmarking documentation, Go version upgrades, performance optimizations in JSON diffing and pointer operations, improved unmarshalling robustness, and more efficient deep copying of JSON values.
Performance & Benchmarking Enhancements:
README.md, detailing how to run and compare benchmarks, and describing benchmark coverage for contributors.Dependency Updates:
go.modand all relevant GitHub Actions workflow files (.github/workflows/compile_examples.yml,.github/workflows/test_go.yml). [1] [2] [3]Performance Optimizations:
difffunction increate.goto use fast path comparisons for primitive types before falling back to deep equality checks, reducing overhead for common cases.Pointeroperations (Set,Remove, andString) inpointer.goby reducing redundant calls, pre-estimating string builder capacity, and using more efficient array manipulation. [1] [2] [3] [4] [5] [6]Type Handling and Robustness:
Operation.UnmarshalJSONinpatch.goto strictly rejectnullvalues for string fields, preventing silent acceptance of invalid input and improving error messages.jsonEqualinapply.goto assume caller-supplied values are already normalized, removing unnecessary normalization steps for performance.Internal Utility Improvements:
pointer.gowith a recursive copy for maps and slices, avoiding the overhead of JSON serialization/deserialization.