Used cfg(test) on some functions over allow dead code and fixed some warnings#12
Open
BoolPurist wants to merge 1 commit into
Open
Conversation
This way we do not need any comments and are more disruptive with code. It allows reduces compile time for the user of the library I removed some previously annotated function with allow dead code Reason: Even the tests do not use them at all. They were private to the library anyway, so the user only would get more compile time. Dead code can be retrieved via source code control if needed later 2. Fixed clippy warning about auto-deref 3. Removed unused code for ThreadSafe trait: ThreadSafe is not used anywhere. Might be a relict of the past ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we do not need any comments and are more disruptive with code. It allows reduces compile time for the user of the library
I removed some previously annotated function with allow dead code.
Reason: Even the tests do not use them at all.
They were private to the library anyway, so the user only would get more compile time.
Dead code can be retrieved via source code control if needed later
Fixed clippy warning about auto-deref
Removed unused code for ThreadSafe trait: ThreadSafe is not used anywhere.
Might be a relict of the past ?