Skip to content

fix: do not yield non-plugin children of a sensor in Sensor#each_plugin #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doudou wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not yield non-plugin children of a sensor in Sensor#each_plugin #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sdf/sensor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def each_direct_plugin(&block)
end

def each_plugin
xml.elements.each do |plugin_xml|
xml.elements.to_a("plugin").each do |plugin_xml|
yield(Plugin.new(plugin_xml, self))
end
end
Expand Down
4 changes: 4 additions & 0 deletions test/test_sensor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ module SDF
root = SDF::Sensor.new(REXML::Document.new("<sensor />").root)
assert root.enum_for(:each_plugin).to_a.empty?
end
it "does not yield non-plugin children" do
root = SDF::Sensor.new(REXML::Document.new("<sensor><pose /></sensor>").root)
assert root.enum_for(:each_plugin).to_a.empty?
end
it "yields the plugins otherwise" do
root = SDF::Sensor.new(REXML::Document.new("<sensor><plugin name=\"0\" /><plugin name=\"1\" /></sensor>").root)

Expand Down