fix(osal): validate all dma_heap nodes before enabling dma_heap alloc…#943
Open
axcda wants to merge 1 commit intorockchip-linux:developfrom
Open
fix(osal): validate all dma_heap nodes before enabling dma_heap alloc…#943axcda wants to merge 1 commit intorockchip-linux:developfrom
axcda wants to merge 1 commit intorockchip-linux:developfrom
Conversation
…ator On systems that only expose /dev/dma_heap/system without system-uncached, MPP incorrectly selects the dma_heap allocator. This causes cache coherency issues (visible as stripe/grid artifacts) when encoding video frames, because the allocated buffers lack proper cache management. Fix by requiring all four dma_heap nodes (system, system-dma32, system-uncached, system-uncached-dma32) to be present before marking the dma_heap allocator as valid. When any node is missing, MPP falls back to the DRM allocator which handles cache correctly. Fixes: nyanmisaka/ffmpeg-rockchip#251 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems that only expose /dev/dma_heap/system without system-uncached, MPP incorrectly selects the dma_heap allocator. This causes cache coherency issues (visible as stripe/grid artifacts) when encoding video frames, because the allocated buffers lack proper cache management.
Fix by requiring all four dma_heap nodes (system, system-dma32, system-uncached, system-uncached-dma32) to be present before marking the dma_heap allocator as valid. When any node is missing, MPP falls back to the DRM allocator which handles cache correctly.
test_rkmpp_synth.mp4