-
-
Notifications
You must be signed in to change notification settings - Fork 18
Refactor connections list with hosted PostgreSQL banner #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lyubov-voloshko
merged 8 commits into
rocket-admin:main
from
karinakharchenko:connection-list-hosted-postgresql
Mar 26, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8e2b8d7
feat: refactor connections list with separate hosted banner, DB grid,…
karinakharchenko d4f316a
fix: lighten hosted PostgreSQL banner gradient for light theme
karinakharchenko ea1722b
connections list: fix colors and states, hosted database
lyubov-voloshko 1f73e41
connections list: minor changes
lyubov-voloshko 3c15bdc
Merge branch 'main' into connection-list-hosted-postgresql
lyubov-voloshko daf5f94
Merge branch 'main' into connection-list-hosted-postgresql
lyubov-voloshko f58e156
fix unit tests
lyubov-voloshko 8408fa5
Merge branch 'connection-list-hosted-postgresql' of https://github.co…
lyubov-voloshko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 26 additions & 22 deletions
48
...tend/src/app/components/connections-list/demo-connections/demo-connections.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,27 @@ | ||
| <h1 *ngIf="!isDemo" class="mat-display-1">Explore demo panels</h1> | ||
| <h1 *ngIf="isDemo" class="mat-display-1">Try out a demo admin panel</h1> | ||
| @if (!isDemo) { | ||
| <h1 class="mat-display-1">Explore demo panels</h1> | ||
| } @else { | ||
| <h1 class="mat-display-1">Try out a demo admin panel</h1> | ||
| } | ||
|
|
||
| <ul class="testConnections"> | ||
| <li *ngFor="let testConnectionItem of testConnections"> | ||
| <a routerLink="/dashboard/{{testConnectionItem.connection.id}}" class="testConnectionLink" | ||
| attr.data-testid="{{testConnectionItem.connection.id}}-test-connection-list-item" | ||
| angulartics2On="click" | ||
| angularticsAction="Connections: open test db is clicked" | ||
| (click)="posthog.capture('Connections: open test db is clicked')" | ||
| [angularticsProperties]="{'dbType': testConnectionItem.connection.type}"> | ||
| <img [src]="testDatabasesIcons[testConnectionItem.connection.type]" | ||
| class="testConnectionLink__icon" | ||
| [alt]="testConnectionItem.connection.type"> | ||
| <div class="testConnectionLink__info"> | ||
| <strong>{{ testConnectionItem.displayTitle }}</strong> | ||
| <span class="testConnectionLink__type">{{ testDatabasesNames[testConnectionItem.connection.type] }}</span> | ||
| </div> | ||
|
|
||
| <mat-icon class="connection__goIcon">arrow_forward</mat-icon> | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| <ul class="demoGrid"> | ||
| @for (testConnectionItem of testConnections; track testConnectionItem.connection.id) { | ||
| <li> | ||
| <a routerLink="/dashboard/{{testConnectionItem.connection.id}}" class="demoCard" | ||
| attr.data-testid="{{testConnectionItem.connection.id}}-test-connection-list-item" | ||
| angulartics2On="click" | ||
| angularticsAction="Connections: open test db is clicked" | ||
| (click)="posthog.capture('Connections: open test db is clicked')" | ||
| [angularticsProperties]="{'dbType': testConnectionItem.connection.type}"> | ||
| <img [src]="testDatabasesIcons[testConnectionItem.connection.type]" | ||
| class="demoCard__icon" | ||
| [alt]="testConnectionItem.connection.type"> | ||
| <div class="demoCard__info"> | ||
| <strong>{{ $any(testConnectionItem).displayTitle }}</strong> | ||
| <span class="demoCard__type">{{ testDatabasesNames[testConnectionItem.connection.type] }}</span> | ||
| </div> | ||
| <mat-icon class="demoCard__arrow">arrow_forward</mat-icon> | ||
| </a> | ||
| </li> | ||
| } | ||
| </ul> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$any(testConnectionItem).displayTitledisables template type-checking. Consider changingtestConnectionsto a typed view-model that includesdisplayTitle(or extendConnectionItem) so this stays type-safe.