Prevent hosted database credentials from being sent to PostHog#1691
Prevent hosted database credentials from being sent to PostHog#1691
Conversation
Add ph-no-capture class to credential containers in the hosted database success dialog and password reset dialog so PostHog autocapture excludes sensitive data (host, port, username, password) from captured events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo hosted database dialog templates are updated to add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Adds PostHog autocapture exclusions around hosted database credential displays to avoid leaking sensitive connection details (host, port, username, password) from dialogs.
Changes:
- Add
ph-no-captureto the credential container in the hosted database reset-password “result” dialog. - Add
ph-no-captureto the credential container in the hosted database success dialog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/app/components/hosted-databases/hosted-database-reset-password-dialog/hosted-database-reset-password-dialog.component.html | Wraps the rendered reset credentials block with ph-no-capture to prevent PostHog DOM autocapture of new credentials. |
| frontend/src/app/components/connections-list/hosted-database-success-dialog/hosted-database-success-dialog.component.html | Wraps the hosted DB success credentials block with ph-no-capture to prevent PostHog DOM autocapture of provisioned credentials. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add ph-no-capture class to credential containers in the hosted database success dialog and password reset dialog so PostHog autocapture excludes sensitive data (host, port, username, password) from captured events.
Summary by CodeRabbit