Initialize sensors, set up FlightComputer singleton structure#90
Open
cschow-ucsd wants to merge 8 commits intorocketproplab:masterfrom
Open
Initialize sensors, set up FlightComputer singleton structure#90cschow-ucsd wants to merge 8 commits intorocketproplab:masterfrom
cschow-ucsd wants to merge 8 commits intorocketproplab:masterfrom
Conversation
…ost getInstance() methods to group initialization in FlightComputer.java
Pumuckl007
requested changes
Apr 17, 2021
Member
Pumuckl007
left a comment
There was a problem hiding this comment.
Could you change the tab size to 2 spaces, not four. Other than that it looks really good and I think it should work well.
Member
Contributor
Author
|
Field declarations should be aligned now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

getInstance()methods in most classes, in favor of initializing all objects inFlightComputerPartially addresses #52, but returning different sensors/simulators has not been completed in
SensorProvider.