Add missing before/on/after plugin hooks across compiler event lifecycle#1707
Draft
Copilot wants to merge 5 commits into
Draft
Add missing before/on/after plugin hooks across compiler event lifecycle#1707Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure every plugin event has beforeAction, action, and afterAction
Add missing before/on/after plugin hooks across compiler event lifecycle
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin API still had lifecycle gaps where some event families exposed only before/after or only on-style hooks. This change completes the lifecycle contract so plugin authors can consistently hook into before, during, and after phases across program, file, scope, and language-service events.
Plugin API surface: complete event triads
Plugin(before*,on*,after*) for event families that were incomplete, including:OnFileTranspileEvent,OnProgramDisposeEvent,AfterProgramDisposeEvent).Runtime emission flow: wire new lifecycle phases
on*and missingbefore*/after*hooks at the correct points in:ProgramBuilderlifecycle (createProgram, prepublish/publish pipeline)Programlifecycle (parse, validate, transpile, dispose, query APIs)Tests: verify new hook coverage
on*hooksDocs: align plugin lifecycle documentation
docs/plugins.mdlifecycle and API sections to reflect new triad hooks and naming.beforeProgramCreate(ProgramBuilder) vson/afterProgramCreate(Program) semantics.Example of the new lifecycle consistency: