H2 #13
Open
H2 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 27, 2017 18:40
romabelka
reviewed
Sep 3, 2017
Owner
romabelka
left a comment
romabelka
left a comment
There was a problem hiding this comment.
Хорошо, но тесты можно писать не только на саги. Еще я не понял зачем ты переписал PeopleForm
romabelka
reviewed
Sep 3, 2017
|
|
||
| class PeopleForm extends Component { | ||
| render() { | ||
| const { handleSubmit, submitting, reset } = this.props; |
Owner
There was a problem hiding this comment.
Возможно у тебя у тебя какие-то особые соображения, поделись. Но вся суть в том, что ты можешь ресетить как часть декларативной логики, при успешном сабмите, а не по клику
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.