Open
Conversation
santib
reviewed
Oct 2, 2020
santib
reviewed
Oct 2, 2020
santib
reviewed
Oct 2, 2020
santib
reviewed
Oct 2, 2020
santib
reviewed
Oct 2, 2020
santib
reviewed
Oct 2, 2020
|
|
||
| shared_examples 'creates the physical file with data' do | ||
| it 'creates the physical file at the given location_url' do | ||
| subject |
Member
There was a problem hiding this comment.
maybe it's a good idea to add expect(File.open(admin_report.reload.location_url)).to_not be before running the subject to make sure that the subject is actually creating it. Same for the other tests
Contributor
Author
There was a problem hiding this comment.
Cannot do File.open of a file that does not exist. I can try to do something like expect { File.open(admin_report.location_url.to_s) }.to raise_exception(Errno::ENOENT), wdyt?
juanmanuelramallo
approved these changes
Oct 16, 2020
juanmanuelramallo
left a comment
juanmanuelramallo
left a comment
There was a problem hiding this comment.
Looking good! Left some non blocking comments
Co-authored-by: Juan Manuel Ramallo <juanmanuelramallo@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configuration for testing and tests for the worker.