Open
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
mjcarroll
reviewed
Mar 9, 2026
|
|
||
| TEST(test_asserts, assertion_exception_what_message) { | ||
| const rcpputils::AssertionException ex("assertion failed"); | ||
| EXPECT_STREQ("assertion failed", ex.what()); |
Member
There was a problem hiding this comment.
Doesn't seem like we are actually testing much here. I guess this is just increasing line coverage?
mjcarroll
approved these changes
Mar 9, 2026
Contributor
Author
|
Pulls: #222
|
fujitatomoya
requested changes
Mar 9, 2026
Comment on lines
+42
to
+49
| TEST(TestGetEnv, test_get_env_returns_string_not_empty_when_set) { | ||
| // Verify set_env_var + get_env_var roundtrip preserves the value exactly. | ||
| EXPECT_TRUE(rcpputils::set_env_var("ROUNDTRIP_TEST", "hello_world")); | ||
| EXPECT_EQ(rcpputils::get_env_var("ROUNDTRIP_TEST"), std::string("hello_world")); | ||
| // Cleanup | ||
| EXPECT_TRUE(rcpputils::set_env_var("ROUNDTRIP_TEST", nullptr)); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
i think this is already tested in test_set_env.
Comment on lines
+100
to
+106
| TEST(TestSetEnv, test_set_env_overwrite_with_longer_value) { | ||
| EXPECT_TRUE(rcpputils::set_env_var("OVERWRITE_VAR", "short")); | ||
| EXPECT_TRUE(rcpputils::set_env_var("OVERWRITE_VAR", "a_much_longer_value_than_before")); | ||
| EXPECT_STREQ("a_much_longer_value_than_before", | ||
| rcpputils::get_env_var("OVERWRITE_VAR").c_str()); | ||
| EXPECT_TRUE(rcpputils::set_env_var("OVERWRITE_VAR", nullptr)); | ||
| } |
Collaborator
There was a problem hiding this comment.
i think this is already tested in test_set_env.
Comment on lines
-22
to
+24
| EXPECT_EQ("test_process", rcpputils::get_executable_name()); | ||
| const std::string name = rcpputils::get_executable_name(); | ||
| EXPECT_FALSE(name.empty()); | ||
| EXPECT_EQ("test_process", name); |
Collaborator
There was a problem hiding this comment.
i cannot tell the difference here... 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increased test coverage
Did you use Generative AI?
Claude Sonnet 4.6