Skip to content

Use ament_set_default_language_standards from ament_cmake_core#548

Open
ahcorde wants to merge 5 commits intorollingfrom
ahcorde/rolling/cmake_language_standard
Open

Use ament_set_default_language_standards from ament_cmake_core#548
ahcorde wants to merge 5 commits intorollingfrom
ahcorde/rolling/cmake_language_standard

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 23, 2026

Description

Related with ament/ament_cmake#621

@ahcorde
Use ament_set_default_language_standards from ament_cmake_core
8630964 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from InvincibleRMC March 23, 2026 15:39
@ahcorde ahcorde self-assigned this Mar 23, 2026
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 23, 2026

Pulls: #548, ament/ament_cmake#621
Gist: https://gist.githubusercontent.com/ahcorde/625e52fa23a766ff8fae9be37ad3ad47/raw/d820803942e8a156af42db30a04fcb6309347102/ros2.repos
BUILD args: --packages-above-and-dependencies ament_cmake_core rcutils
TEST args: --packages-above ament_cmake_core rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18622

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Mar 23, 2026
Closed
fujitatomoya
fujitatomoya approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, lgtm!

@ahcorde
use ament_cmake_ros
cbb1ee1 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 26, 2026

Pulls: #548, ros2/ament_cmake_ros#62
Gist: https://gist.githubusercontent.com/ahcorde/3e7ab21988cdd588ff217c5561a8ba80/raw/bd52d1d2df3a4da8b2da4f06ef3ebf0a122e7a70/ros2.repos
BUILD args: --packages-above-and-dependencies ament_cmake_ros rcutils rmw_test_fixture_implementation
TEST args: --packages-above ament_cmake_ros rcutils rmw_test_fixture_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18675

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Mar 26, 2026
Open
InvincibleRMC
InvincibleRMC reviewed Mar 26, 2026
View reviewed changes
@ahcorde @InvincibleRMC
Update CMakeLists.txt
0320f06 
Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 30, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 31, 2026

Pulls: #548, ros2/ament_cmake_ros#62
Gist: https://gist.githubusercontent.com/ahcorde/9559d38bc1bba1117521e3b1ca1486d7/raw/bd52d1d2df3a4da8b2da4f06ef3ebf0a122e7a70/ros2.repos
BUILD args: --packages-above-and-dependencies ament_cmake_ros rcutils rmw_test_fixture_implementation
TEST args: --packages-above ament_cmake_ros rcutils rmw_test_fixture_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18748

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Copy Markdown

InvincibleRMC commented Apr 8, 2026

Pulls: ros2/ament_cmake_ros#62, #548
Gist: https://gist.githubusercontent.com/InvincibleRMC/fdfe0c78f32f762e6ac42154df9dce19/raw/324354195f82453e573c5173cddeed2b61497ae1/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies ament_cmake_ros_core rcutils
TEST args: --packages-above ament_cmake_ros_core rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18877

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski
Copy link
Copy Markdown

jmachowinski commented Apr 8, 2026

We are seeing downstream compile errors, the reason for this is, that the linking is done public, and not private.
We got two options here :
link public, this enforces the downstream libs to be at least c++20. Or if we don't want this link everything private.

If we link public, we need to export the cmake package providing the target.
E.g.

ament_export_dependencies(ament_cmake ament_cmake_ros_core)

fix: Fix compilation of downstream packages
239830f 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski
Copy link
Copy Markdown

jmachowinski commented Apr 8, 2026

Pulls: ros2/ament_cmake_ros#62, #548
Gist: https://gist.githubusercontent.com/jmachowinski/5a5aeb4a178e96f09bcea09ea11d167e/raw/d2acee73ba7751b94dc0ac40bbc35d9d717aba24/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18893

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

chore: Fix lint waring
54853ec 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski
Copy link
Copy Markdown

jmachowinski commented Apr 9, 2026

Pulls: ros2/ament_cmake_ros#62, #548, ros2/rclcpp#3124
Gist: https://gist.githubusercontent.com/jmachowinski/1538e0f1074c2a0133830f9b6e76ee32/raw/31a05eaaf436bc349c5bf99faec772cce9b5f581/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18900

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski mentioned this pull request Apr 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@InvincibleRMC InvincibleRMC InvincibleRMC left review comments

@jmachowinski jmachowinski jmachowinski requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @InvincibleRMC @jmachowinski @fujitatomoya