test: fix unstable test cases

[chenjiahan]

Summary

Fix unstable test cases.

[Copilot]

Pull request overview

This PR addresses test stability issues by refactoring how tests handle command-line arguments and changing the assertion library from assert.deepStrictEqual to expect().toBe(). The main changes involve removing direct manipulation of process.argv in tests and instead passing arguments through a new argv parameter in the create function.

Key changes:

• Replaced assert with expect in test assertions for cleaner test syntax
• Added an argv parameter to the create() function to allow tests to pass arguments without modifying process.argv
• Updated parseArgv() to accept a parameter instead of directly accessing process.argv

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/index.test.ts	Migrated from assert.deepStrictEqual to expect().toBe() for assertions
test/custom-tools.test.ts	Replaced process.argv manipulation with argv parameter; changed test to import from ../src and use rimraf for cleanup
test/agents.test.ts	Replaced process.argv manipulation with argv parameter; changed import to ../src
src/index.ts	Added argv parameter to create() function and updated parseArgv() to accept arguments; removed async from runCommand()
package.json	Added rimraf dependency for test file cleanup
pnpm-lock.yaml	Lock file updates for rimraf and its dependencies
.gitignore	Added test-temp-* pattern to ignore test output directories

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This test imports from ../src instead of ../dist/index.js, which is inconsistent with test/index.test.ts that imports from ../dist/index.js. Consider using the same import path across test files for consistency, especially since the built distribution is what will be published.

Suggested change

	import { create } from '../src';
	import { create } from '../dist/index.js';

[Copilot]

The test output directory test-temp-output is now placed inside fixturesDir (fixtures/basic), which means test outputs will be created within the fixtures directory. This could lead to:

1. Test artifacts polluting the fixtures directory
2. Potential conflicts if fixtures are version-controlled
3. Issues if fixtures directory is read-only

Consider placing the test output directory at the test root level instead:

const testDir = path.join(__dirname, 'test-temp-output');

Suggested change

	const testDir = path.join(fixturesDir, 'test-temp-output');
	const testDir = path.join(__dirname, 'test-temp-output');

[Copilot]

The test output directory test-temp-output is now placed inside fixturesDir (fixtures/agents-md), which means test outputs will be created within the fixtures directory. This could lead to:

1. Test artifacts polluting the fixtures directory
2. Potential conflicts if fixtures are version-controlled
3. Issues if fixtures directory is read-only

Consider placing the test output directory at the test root level instead:

const testDir = path.join(__dirname, 'test-temp-output');

Suggested change

	const testDir = path.join(fixturesDir, 'test-temp-output');
	const testDir = path.join(__dirname, 'test-temp-output');

[Copilot]

Using npx rimraf ${testFile} with string interpolation could be problematic if the file path contains spaces or special characters. Consider using proper argument quoting or a more robust approach:

command: `npx rimraf "${testFile}"`

Or better yet, use the rimraf package directly instead of relying on npx execution in tests.

[Copilot]

The test file path path.join(__dirname, 'node_modules', 'test.txt') creates a file in the test directory's node_modules, which is unusual and potentially problematic. This could:

1. Interfere with the actual node_modules structure
2. Fail if node_modules doesn't exist or has restricted permissions
3. Not be properly cleaned up by git (node_modules is typically gitignored)

Consider using the testDir path instead, which is properly cleaned up in the beforeEach hook:

const testFile = path.join(testDir, 'test.txt');

Suggested change

	const testFile = path.join(__dirname, 'node_modules', 'test.txt');
	const testFile = path.join(testDir, 'test.txt');

[Copilot]

This test imports from ../src instead of ../dist/index.js, which is inconsistent with test/index.test.ts that imports from ../dist/index.js. Consider using the same import path across test files for consistency, especially since the built distribution is what will be published.

Suggested change

	import { create } from '../src';
	import { create } from '../dist/index.js';