-
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: update peer dependency version for @rspack/core #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request broadens the compatibility of the project by updating the peer dependency for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the peerDependency for @rspack/core. While the new range correctly adds support for upcoming v1 and v2 versions, it drops support for the existing 0.x versions. This is a breaking change that will affect users on the current stable version of @rspack/core. This should be reflected with a major version bump for this package and an appropriate commit message.
| }, | ||
| "peerDependencies": { | ||
| "@rspack/core": "0.x || 1.x" | ||
| "@rspack/core": "^1.0.0 || ^2.0.0-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a breaking change by dropping support for 0.x versions of @rspack/core. Since the current stable version on npm is in the 0.x range, this will cause peer dependency issues for existing users.
Breaking changes should be accompanied by a major version bump (e.g., to 7.0.0) and a conventional commit message that indicates a breaking change (e.g., feat!: ... or a BREAKING CHANGE: footer).
If you intend to maintain backward compatibility, please consider expanding the range instead of replacing it.
| "@rspack/core": "^1.0.0 || ^2.0.0-0" | |
| "@rspack/core": "0.x || ^1.0.0 || ^2.0.0-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the peer dependency version range for @rspack/core to add support for upcoming v2 pre-release versions while removing support for v0.x versions. The change modifies the version range from 0.x || 1.x to ^1.0.0 || ^2.0.0-0, which is a breaking change for users still on @rspack/core 0.x.
Changes:
- Updated
@rspack/corepeer dependency to support v1.x stable and v2.0.0 pre-release versions - Dropped support for @rspack/core v0.x versions
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated the
@rspack/corepeer dependency version range to^1.0.0 || ^2.0.0-0inpackage.json, allowing compatibility with both stable v1 and pre-release v2 versions.