Skip to content

Conversation

@chenjiahan
Copy link
Member

Updated the @rspack/core peer dependency version range to ^1.0.0 || ^2.0.0-0 in package.json, allowing compatibility with both stable v1 and pre-release v2 versions.

Copilot AI review requested due to automatic review settings January 19, 2026 05:13
@gemini-code-assist
Copy link

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request broadens the compatibility of the project by updating the peer dependency for @rspack/core. The change ensures that the project can seamlessly integrate with both the current stable version and upcoming pre-release versions of the dependency, enhancing flexibility and preparing for future updates.

Highlights

  • Peer Dependency Update: The peer dependency version range for @rspack/core has been updated in package.json.
  • Expanded Compatibility: The new version range ^1.0.0 || ^2.0.0-0 allows compatibility with both stable v1 and pre-release v2 versions of @rspack/core.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the peerDependency for @rspack/core. While the new range correctly adds support for upcoming v1 and v2 versions, it drops support for the existing 0.x versions. This is a breaking change that will affect users on the current stable version of @rspack/core. This should be reflected with a major version bump for this package and an appropriate commit message.

},
"peerDependencies": {
"@rspack/core": "0.x || 1.x"
"@rspack/core": "^1.0.0 || ^2.0.0-0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a breaking change by dropping support for 0.x versions of @rspack/core. Since the current stable version on npm is in the 0.x range, this will cause peer dependency issues for existing users.

Breaking changes should be accompanied by a major version bump (e.g., to 7.0.0) and a conventional commit message that indicates a breaking change (e.g., feat!: ... or a BREAKING CHANGE: footer).

If you intend to maintain backward compatibility, please consider expanding the range instead of replacing it.

Suggested change
"@rspack/core": "^1.0.0 || ^2.0.0-0"
"@rspack/core": "0.x || ^1.0.0 || ^2.0.0-0"

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the peer dependency version range for @rspack/core to add support for upcoming v2 pre-release versions while removing support for v0.x versions. The change modifies the version range from 0.x || 1.x to ^1.0.0 || ^2.0.0-0, which is a breaking change for users still on @rspack/core 0.x.

Changes:

  • Updated @rspack/core peer dependency to support v1.x stable and v2.0.0 pre-release versions
  • Dropped support for @rspack/core v0.x versions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 836f1a8 into main Jan 19, 2026
3 checks passed
@chenjiahan chenjiahan deleted the update_peers_0119 branch January 19, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants