fix: update peerDependencies to support Rsbuild v2 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the peerDependencies specification for @rsbuild/core to support Rsbuild v2 by changing from 1.x to ^1.0.0 || ^2.0.0-0. This enables the plugin to work with both Rsbuild v1 and v2, including v2 pre-release versions.
Changes:
- Updated the peer dependency range for
@rsbuild/coreto accept both v1 (>=1.0.0) and v2 (including pre-releases >=2.0.0-0)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "peerDependencies": { | ||
| "@rsbuild/core": "1.x" | ||
| "@rsbuild/core": "^1.0.0 || ^2.0.0-0" |
There was a problem hiding this comment.
The peer dependency update to support Rsbuild v2 lacks corresponding test coverage. The test suite should include tests that verify compatibility with Rsbuild v2 APIs, or at minimum, CI configuration should test against both v1 and v2 versions to ensure the plugin works correctly with both major versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.