Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's build system to be compatible with Rsbuild v2. This involved updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds compatibility for Rsbuild v2 by updating @rsbuild/core to a beta version and adjusting the plugin code to handle API changes. The changes in src/plugin.ts are a pragmatic way to maintain backward compatibility. My main feedback is about the use of a beta dependency, which could introduce instability.
There was a problem hiding this comment.
Pull request overview
Updates the plugin and its E2E fixture to work with Rsbuild v2 (while keeping fallback behavior for Rsbuild v1), and bumps local dev tooling to exercise v2 in CI/tests.
Changes:
- Bump
@rsbuild/coredev dependency (and lockfile) to^2.0.0-beta.6. - Adjust
pluginSourceBuildbundler-chain hooks to tolerate Rsbuild v2 identifier/type changes (and keep a webpack/Rsbuild v1 fallback path). - Mark the E2E test app package as ESM (
"type": "module") for config loading compatibility.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/app/package.json |
Sets ESM package type for the E2E fixture app. |
src/plugin.ts |
Updates bundler-chain rule/plugin handling for Rsbuild v2 compatibility and keeps a v1 webpack fallback. |
pnpm-lock.yaml |
Locks updated Rsbuild/Rspack dependency graph for v2 beta. |
package.json |
Bumps devDependency on @rsbuild/core to v2 beta. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add compatibility for Rsbuild v2.