feat!: remove bonjour feature

[chenjiahan]

Remove the bonjour option from rspack-dev-server.

bonjour is rarely used in modern setups and adds unnecessary dependencies. Major modern dev tools such as Rsbuild, Vite, and Next.js do not provide this feature.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the rspack-dev-server by eliminating the bonjour feature. This change reduces the project's dependency footprint and aligns it with modern development tool practices, as the feature is rarely utilized. The removal simplifies the codebase and improves maintainability by shedding an unnecessary component.

Highlights

• Feature Removal: The bonjour feature has been completely removed from rspack-dev-server. This includes all related code, configuration options, and dependencies.
• Dependency Cleanup: Removed bonjour-service and its associated type definitions (@types/bonjour), along with several transitive dependencies like @leichtgewicht/ip-codec, dns-packet, multicast-dns, and thunky from package.json and pnpm-lock.yaml.
• Test Suite Update: All end-to-end tests and snapshots specifically covering the bonjour feature have been removed, reflecting its deprecation.
• Development Tooling: The default formatter in .vscode/settings.json has been switched from biomejs.biome to esbenp.prettier-vscode for various file types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .vscode/settings.json
  • Updated default formatter from Biome to Prettier for JSON, TypeScript, JavaScript, JavaScript React, and CSS files.
• package.json
  • Removed @types/bonjour and bonjour-service from dependencies.
• pnpm-lock.yaml
  • Removed all entries related to bonjour-service and its transitive dependencies, including @types/bonjour, @leichtgewicht/ip-codec, dns-packet, multicast-dns, and thunky.
• src/config.ts
  • Removed BonjourOptions import.
  • Removed the bonjour property from the ResolvedDevServer interface.
• src/server.ts
  • Removed BonjourOptions and Bonjour type imports.
  • Removed the bonjour property from the Configuration interface.
  • Removed the bonjour property from the Server class.
  • Removed runBonjour and stopBonjour methods.
  • Removed all logic and logging related to the bonjour feature.
• src/types.ts
  • Removed Bonjour and BonjourOptions type exports and imports from bonjour-service.
• tests/e2e/snapshots/bonjour.test.js.snap.webpack5
  • Removed the entire snapshot file for bonjour tests.
• tests/e2e/bonjour.test.js
  • Removed the entire end-to-end test file for the bonjour option.
• tests/helpers/ports-map.js
  • Removed bonjour and cli-bonjour entries from the test port mapping configuration.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a breaking change by removing the bonjour feature from rspack-dev-server. The implementation involves removing the bonjour-service dependency and all associated code, including types, configuration options, and implementation logic. The corresponding tests and test snapshots for the bonjour feature have also been correctly removed. The changes appear to be complete and consistent with the stated goal of removing this feature. A change to the VS Code settings to switch the default formatter to Prettier is also included. No issues were found during the review.

[Copilot]

Pull request overview

This PR removes the bonjour/ZeroConf (mDNS) broadcasting feature from @rspack/dev-server, including its runtime implementation, type surface, tests, and dependency footprint.

Changes:

• Removed the bonjour option from dev-server configuration/types and deleted the implementation hooks in src/server.ts.
• Deleted the e2e test suite and snapshots for bonjour, and removed related port mappings.
• Dropped bonjour-service and related type/dependency entries from package.json and pnpm-lock.yaml.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/helpers/ports-map.js	Removes bonjour and cli-bonjour port allocations used by the deleted tests.
tests/e2e/bonjour.test.js	Deletes the e2e coverage for the bonjour option.
tests/e2e/snapshots/bonjour.test.js.snap.webpack5	Removes snapshots tied to the deleted bonjour tests.
src/types.ts	Removes exported Bonjour/BonjourOptions types sourced from bonjour-service.
src/server.ts	Removes the bonjour configuration option and all runtime start/stop + logging behavior.
src/config.ts	Removes bonjour from the resolved dev server typing.
pnpm-lock.yaml	Removes bonjour-service and transitive packages from the lockfile.
package.json	Removes bonjour-service and @types/bonjour dependencies.
.vscode/settings.json	Changes VS Code default formatter settings (not directly related to bonjour removal).

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.