Add unit tests for rstudio-library chart.#764
Merged
bschwedler merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
bschwedler
force-pushed
the
rstudio-library-unittest
branch
from
8fce3ff to
ebc81cc
Compare
bschwedler
force-pushed
the
rstudio-library-unittest
branch
4 times, most recently
from
7c435e1 to
b7f30c5
Compare
Contributor
Author
|
@jforest I believe this should be good to go now. |
jforest
reviewed
Mar 18, 2026
Create test harness chart for unit testing rstudio-library templates. Library charts cannot be tested directly, so this application chart depends on rstudio-library and will exercise its templates.
bschwedler
force-pushed
the
rstudio-library-unittest
branch
from
6ca90db to
cadb4f3
Compare
- Update maintainer from sol-eng/docker@rstudio.com to rstudio/docker@posit.co to match posit-chronicle convention - Use tilde version constraint (~0.1.0) for rstudio-library dependency so the test harness auto-tracks patch releases - Unify CI unittest loops into a single loop over both charts/ and other-charts/ with a consistent tests/ directory guard
bschwedler
force-pushed
the
rstudio-library-unittest
branch
from
cadb4f3 to
8662cf3
Compare
jforest
approved these changes
Mar 25, 2026
Contributor
jforest
left a comment
jforest
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback!
I checked it over again, and then I threw claude at it this afternoon and the only item it came up with that is of any concern is:
- No negative tests for config formatters (e.g., what happens with
empty config, nil values). Not blocking but could improve robustness
later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create test harness chart for unit testing rstudio-library templates.
Library charts cannot be tested directly, so this application chart
depends on rstudio-library and will exercise its templates.
rstudio-library-testharness chart inother-charts/