Draft
Conversation
bschwedler
force-pushed
the
worktree-workbench-session-init
branch
from
07dde72 to
9813ec3
Compare
Change the default session image from rstudio/r-session-complete
to rstudio/workbench-session and enable session component delivery
via init containers by default. The launcher configures a
workbench-session-init container that injects Workbench session
components into session pods at startup.
- Add session.components.enabled (default true) and
session.components.sessionInit values for init container config
- Configure rserver.conf with launcher-sessions-auto-update and
launcher-sessions-init-container-image-{name,tag} when both
launcher and components are enabled
- When launcher is disabled, components are silently ignored
- Set session.components.enabled=false and session.image.repository
to rstudio/r-session-complete to restore classic behavior
- Bump chart version to 0.11.0 (breaking change)
bschwedler
force-pushed
the
worktree-workbench-session-init
branch
from
9813ec3 to
508d490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will default the helm chart to using the workbench-session and workbench-session-init containers by default.
session.components.enabled(defaulttrue) andsession.components.sessionInitvalues for init container configrserver.confwithlauncher-sessions-auto-updateandlauncher-sessions-init-container-image-{name,tag}when bothlauncher and components are enabled
session.image.repository: rstudio/r-session-completeandsession.components.enabled: false0.11.0(breaking change)