Changing labels from 'key' to 'getenv'#229
Closed
nwstephens wants to merge 5 commits intorstudio:masterfrom
nwstephens:master
Closed
Changing labels from 'key' to 'getenv'#229nwstephens wants to merge 5 commits intorstudio:masterfrom nwstephens:master
nwstephens wants to merge 5 commits intorstudio:masterfrom
nwstephens:master
Conversation
nwstephens
commented
May 10, 2021
- Changes all references from 'key' to 'getenv', which is slightly more descriptive.
- Makes getenv case sensitive by removing 'toupper'.
- Changes error message in Connect to be more descriptive.
Feature/ask for secret envvar
Contributor
|
If we want something more descriptive than "key"; that is, we want to document this as specifically being tied to an environment variable, then I'd suggest calling it "envvar". Also: are we sure we want to call this something other than "key"? What if we wanted to eventually look up "key" from something that wasn't an environment variable (e.g. some kind of special integration with |
Author
|
We decided to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.