Conversation
Make tests succeed so current behavior stands our clearer.
* test/hui-tests.el (hui--kill-region-delimited-text-and-yank-back):
Remove expected-result tag and expand tests.
(hui-tests--selectable-thing-and-bounds): Add test.
rswgnu
approved these changes
Mar 26, 2026
Owner
|
Ya, let's discuss on Sunday. Approved though. |
Collaborator
Author
Thanks. Let's try this approach instead to see if we can fix this if fixing is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make tests succeed so current behavior stands our clearer.
Remove expected-result tag and expand tests.
(hui-tests--selectable-thing-and-bounds): Add test.
Why
We have had this test in state expected to fail for a long time but
not fixed why it is failing. This PR flips the coin and expands the
tests to cover more cases. All tests are now set to succeed and by
that the current behavior is documented.
Note
There are likely more cases to cover since the functions under test
depend on character classes.
What should really happen is tricky so I hope it is easier to review
using this format of the test.