Enable monitoring in the examples that use the security plugins #752
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,9 +10,9 @@ | |
| use the software. | ||
| --> | ||
| <dds xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="http://community.rti.com/schema/7.6.0/rti_dds_qos_profiles.xsd"> | ||
| <qos_library name="network_capture_Library"> | ||
| <qos_profile name="network_capture_ProfileCommon" base_name="BuiltinQosLib::Generic.Security" > | ||
| <domain_participant_qos> | ||
| <property> | ||
| <value> | ||
|
|
@@ -21,20 +21,41 @@ | |
| <value>file:security/ecdsa01/certs/ca_cert.pem</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.access.governance</name> | ||
| <value>file:security/ecdsa01/xml/signed/signed_Governance.p7s</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.access.permissions_ca</name> | ||
| <value>file:security/ecdsa01/certs/ca_cert.pem</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.crypto.rtps_psk_secret_passphrase</name> | ||
| <value>data:,0:PLEASE-CHANGE-THIS-DEFAULT-SEED</value> | ||
| </element> | ||
| </value> | ||
| </property> | ||
| </domain_participant_qos> | ||
| </qos_profile> | ||
| <qos_profile name="network_capture_ProfileA" base_name="network_capture_ProfileCommon" is_default_qos="true"> | ||
| <participant_factory_qos> | ||
| <monitoring> | ||
| <distribution_settings> | ||
| <dedicated_participant> | ||
| <participant_qos_profile_name>network_capture_Library::network_capture_ProfileMonitor</participant_qos_profile_name> | ||
| </dedicated_participant> | ||
| </distribution_settings> | ||
| </monitoring> | ||
| </participant_factory_qos> | ||
| <domain_participant_qos> | ||
| <property> | ||
| <value> | ||
| <element> | ||
| <name>dds.sec.auth.identity_certificate</name> | ||
| <value>file:security/ecdsa01/certs/peer1_cert.pem</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.auth.private_key</name> | ||
| <value>file:security/ecdsa01/certs/peer1_key.pem</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.access.permissions</name> | ||
|
|
@@ -72,5 +93,37 @@ | |
| </property> | ||
| </domain_participant_qos> | ||
| </qos_profile> | ||
| <qos_profile name="network_capture_ProfileMonitor"> | ||
| <base_name> | ||
| <element>network_capture_Library::network_capture_ProfileCommon</element> | ||
| <element>BuiltinQosLib::Generic.Monitoring2</element> | ||
|
Contributor
There was a problem hiding this comment. I think this composition goes against our best practices. See: Best Practices for Inheritance and Composition: Use QoS Profiles for inheritance only, never composition. None of these two are snippets. If you want to follow this approach, I would use |
||
| </base_name> | ||
| <domain_participant_qos> | ||
| <resource_limits> | ||
| <participant_property_string_max_length> | ||
| 8192 | ||
| </participant_property_string_max_length> | ||
| <participant_property_list_max_length> | ||
| 40 | ||
|
Contributor
There was a problem hiding this comment. Do we really need 40 properties here? That seems too much. |
||
| </participant_property_list_max_length> | ||
| </resource_limits> | ||
| <property> | ||
| <value> | ||
| <element> | ||
| <name>dds.sec.auth.identity_certificate</name> | ||
| <value>file:security/ecdsa01/certs/peerM_cert.pem</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.auth.private_key</name> | ||
| <value>file:security/ecdsa01/certs/peerM_key.pem</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.sec.access.permissions</name> | ||
| <value>file:security/ecdsa01/xml/signed/signed_PermissionsM.p7s</value> | ||
| </element> | ||
| </value> | ||
| </property> | ||
| </domain_participant_qos> | ||
| </qos_profile> | ||
| </qos_library> | ||
| </dds> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 7.7.0 already?