Add compile/link flags to force debug symbols even for Release builds.#125
Open
jack-pappas wants to merge 1 commit intomasterfrom
Open
Add compile/link flags to force debug symbols even for Release builds.#125jack-pappas wants to merge 1 commit intomasterfrom
jack-pappas wants to merge 1 commit intomasterfrom
Conversation
OrestZborowski-SIG
requested changes
Apr 8, 2022
| set_target_properties(riptide_cpp PROPERTIES PDB_NAME ${_PYTHON_EXTENSION_PDB_NAME}) | ||
| endif() | ||
|
|
||
| ################################################################################ |
Contributor
There was a problem hiding this comment.
Why not add these into the appropriate compiler sections on lines 3+?
The correct compiler detection is already done up there, and the debug flags can simply be added to the right section.
Contributor
There was a problem hiding this comment.
Ah, these compile flags were lifted from the main flags in the toplevel CMakeLists.txt.
The dups should be removed and they should be converted over into target-based flags/etc...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling a CMake release build, CMake doesn't invoke the compiler / linker with flags needed to preserve debugging information. There is a
RelWithDebInfotarget which does set these flags, but it sets the optimization a bit lower thanReleaseto favor better debugging over performance optimizations. This change forces the flags to be enabled in all builds (evenRelease), while keeping all release optimizations enabled. (Note: this can mean the debugging information isn't completely accurate or has some missing information due to compiler optimizations; but it will be enough to decode the stack frames withgdborwindbgto see the function names.)This change also enables link-time code generation (LTCG) / interprocedural optimization (IPO) when supported by the compiler.