[Fixes #246] Don't run file tasks needlessly (2nd attempt)#257
Open
grzuy wants to merge 3 commits intoruby:masterfrom
Open
[Fixes #246] Don't run file tasks needlessly (2nd attempt)#257grzuy wants to merge 3 commits intoruby:masterfrom
grzuy wants to merge 3 commits intoruby:masterfrom
Conversation
grzuy
changed the title
This was referenced Feb 22, 2018
Contributor
Author
|
I solved conflicts with |
Contributor
Author
|
Code Climate is showing an issue to fix, apparently because one of the @rake-maintainers How do you handle these cases? Should I attempt to fix the issue as part of this PR? Or you handle those refactors as separate PRs? I checked Code Climate issue and I already had some ideas on how to refactor, but wanted to ask first given it might end up being not a simple refactor. Thank you. |
da2x
reviewed
Sep 17, 2021
| prereq_task.timestamp > stamp | ||
| end | ||
| } | ||
| prerequisite_tasks.any? { |task| task.timestamp > stamp } |
Contributor
There was a problem hiding this comment.
You’re removing functionality here like the rake --build-all flag and application scoping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt at fixing #246.