Limit calls to Dir.chdir in Rake::Application#365
Open
jonathanhefner wants to merge 1 commit intoruby:masterfrom
Open
Limit calls to Dir.chdir in Rake::Application#365jonathanhefner wants to merge 1 commit intoruby:masterfrom
jonathanhefner wants to merge 1 commit intoruby:masterfrom
Conversation
jonathanhefner
commented
Oct 17, 2020
jonathanhefner
commented
Oct 17, 2020
lib/rake/application.rb
Outdated
Comment on lines
277
to
278
| Dir.chdir(dir) do | ||
| Dir.glob(@rakefiles.map { |name| escape_glob(name) }).first || @rakefiles.find(&:empty?) |
Author
There was a problem hiding this comment.
When support for Ruby < 2.5 is dropped, this Dir.chdir can be replaced with Dir.glob's base kwarg.
jonathanhefner
force-pushed
the
limit-chdir-calls
branch
4 times, most recently
from
20a2140 to
856409f
Compare
This reduces "conflicting chdir during another chdir block" warnings when calling `Rake::Application#run` inside a `Dir.chdir` block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces "conflicting chdir during another chdir block" warnings when calling
Rake::Application#runinside aDir.chdirblock.