Ignore warnings with spec different platforms by hsbt · Pull Request #8508 · ruby/rubygems

hsbt · 2025-02-19T09:52:15Z

What was the end-user or developer problem that led to this PR?

I'm working to provide shared GEM_HOME for all of Ruby versions and platforms.

If I used CRuby and jruby-launcher gem with that environment, RubyGems warns the following:

Source locally installed gems is ignoring #<Bundler::StubSpecification name=jruby-launcher version=1.1.19 platform=java> because it is missing extensions

In another case, I use JRuby and run gem -v. RubyGems warns all of C extension gem:

Ignoring RedCloth-4.3.4 because its extensions are not built. Try: gem pristine RedCloth --version 4.3.4
Ignoring RedCloth-4.3.3 because its extensions are not built. Try: gem pristine RedCloth --version 4.3.3
Ignoring RedCloth-4.3.2 because its extensions are not built. Try: gem pristine RedCloth --version 4.3.2
Ignoring aliyun-sdk-0.8.0 because its extensions are not built. Try: gem pristine aliyun-sdk --version 0.8.0
Ignoring amatch-0.4.1 because its extensions are not built. Try: gem pristine amatch --version 0.4.1
...

What is your fix for the problem, implemented in this PR?

I skip to warn with these cases.

TODO

write test code and consider to another cases.

Make sure the following tasks are checked

Describe the problem / feature
Write tests for features and bug fixes
Write code to solve the problem
Make sure you follow the current code style and write meaningful commit messages without tags

deivid-rodriguez · 2025-02-19T13:42:37Z

This sounds like #3520. A plan for making this work was sketched at #7372, just never implemented.

hsbt · 2025-02-20T08:55:46Z

/cc @headius

deivid-rodriguez · 2025-02-20T11:41:15Z

For what it's worth, I don't think this is the right fix because it will hide all instances of this warning in JRuby, not just the ones that are actually false positives. I'd prefer that we work on a proper solution.

hsbt · 2025-02-20T11:48:47Z

I don't imagine missing_extension? is true with JRuby platform. Do you have example for that?

deivid-rodriguez · 2025-02-20T12:03:38Z

If a extension builds specific artifacts only under JRuby, but does not build those artifacts when installed under a different implementation, then if you switch to JRuby, you can't use the installation as is, but the artifacts will need to be built for JRuby, right?

For example, will jruby-launcher extension work on JRuby if installed under non-jruby?

segiddins · 2025-02-20T16:42:22Z

-      warn "Source #{source} is ignoring #{self} because it is missing extensions"
+      # If we share GEM_HOME for all of Ruby platform, the platform specific gem always warn that specification.
+      # ex `jruby-launcher` and CRuby
+      if platform == Gem::Platform::RUBY && RUBY_ENGINE != "jruby"


Why is this only limited to jruby?

headius · 2025-04-09T13:57:19Z

Sorry I missed this for a while. Answers to some questions:

I don't think this is the right fix because it will hide all instances of this warning in JRuby

In general, extensions built for one configuration of JRuby (JRuby version plus Java version) will work on any other configuration. We do not expose a version-specific C API, so there's nothing to recompile, and Java-based extensions are shipped in a pre-built form. Unless an extension is using Java version-specific APIs (I don't know of any that do this), we do not need separate builds for each configuration.

For example, will jruby-launcher extension work on JRuby if installed under non-jruby?

jruby-launcher is a "-java" platform gem, so I don't expect CRuby users will ever install it. But even if they did, it just builds a plain C-based executable that has no dependencies on a specific JRuby or JVM version.

Why is this only limited to jruby?

Basically, this extension warning makes no sense for JRuby, because:

Gems that contain Java extensions should ship them pre-compiled. Changing JRuby or Java version should have no effect on these.
Gems that actually build something when installed in JRuby don't depend on any version-specific API like they do in CRuby. Usually, they produce a standalone dll or executable that will work across JRuby+Java configurations.
Gems that generate a stub makefile (and build nothing) obviously don't need this check at all.

Basically, gems with native code installed on JRuby should work on just about any supported configuration of JRuby + Java. The warning is (almost always?) useless for us.

I got sick of seeing these warnings again today and was about to monkey-patch RubyGems to stop producing this warning, but this PR would probably be a better option.

(Edit: "exceptions" => "extensions")

headius · 2025-04-09T14:07:47Z

The jruby-launcher gem actually exposes another problem with this warning: it does not actually create an extension for the missing_extension? check to find. Instead, it just builds an executable that it installs in $JRUBY_HOME/bin/jruby:

[] tmp $ gem install jruby-launcher
Fetching jruby-launcher-2.0.0-java.gem
Building native extensions. This could take a while...
Successfully installed jruby-launcher-2.0.0-java
Parsing documentation for jruby-launcher-2.0.0-java
Installing ri documentation for jruby-launcher-2.0.0-java
Done installing documentation for jruby-launcher after 1 seconds
1 gem installed
[] tmp $ bundle                    
Source locally installed gems is ignoring #<Bundler::StubSpecification name=jruby-launcher version=2.0.0.pre2 platform=java> because it is missing extensions
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

So there's basically no way to avoid this warning when using bundler and the jruby-launcher gem.

headius · 2025-04-09T14:10:17Z

So there's basically no way to avoid this warning when using bundler and the jruby-launcher gem.

Oops, I did not notice it was complaining about the "2.0.0.pre2" version of the jruby-launcher gem, so that was a red herring. But it is still a problem when switching Java versions, even though the installed executable works just fine:

[] tmp $ jruby -v                  
jruby 10.0.0.0-SNAPSHOT (3.4.2) 2025-04-09 e2909f9baf OpenJDK 64-Bit Server VM 21.0.5+11-LTS on 21.0.5+11-LTS +indy +jit [arm64-darwin]
[] tmp $ gem install jruby-launcher
Building native extensions. This could take a while...
Successfully installed jruby-launcher-2.0.0-java
Parsing documentation for jruby-launcher-2.0.0-java
Done installing documentation for jruby-launcher after 0 seconds
1 gem installed
[] tmp $ bundle   
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
[] tmp $ pickjdk 24
/Library/Java/JavaVirtualMachines/jdk-24.jdk/Contents/Home
[] tmp $ bundle
Fetching gem metadata from https://rubygems.org/.
Source rubygems repository https://rubygems.org/ or installed locally is ignoring #<Bundler::StubSpecification name=resolv version=0.6.0 platform=ruby> because it is missing extensions
Source rubygems repository https://rubygems.org/ or installed locally is ignoring #<Bundler::StubSpecification name=jruby-launcher version=2.0.0 platform=java> because it is missing extensions
Source rubygems repository https://rubygems.org/ or installed locally is ignoring #<Bundler::StubSpecification name=bindex version=0.8.1 platform=ruby> because it is missing extensions
Resolving dependencies...
Installing resolv 0.6.0 with native extensions
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

The main problem is when switching Java version, since that version gets baked into the extension dir and used for the missing check.

hsbt · 2026-04-01T08:44:40Z

I simplified this by having missing_extensions? always return false on JRuby. The check is unnecessary because Java extensions are shipped pre-compiled and don't need to be rebuilt across JRuby or Java versions.

Copilot

Pull request overview

This PR aims to reduce noisy “missing extensions” warnings when using a shared GEM_HOME across multiple Ruby engines/platforms (e.g., CRuby + JRuby), especially when gems for other platforms are present.

Changes:

Special-cases JRuby by forcing missing_extensions? to return false in RubyGems Specification/StubSpecification and Bundler StubSpecification.
Updates RubyGems and Bundler test expectations to avoid stderr warnings on JRuby.
Adjusts several tests to branch on RUBY_ENGINE == "jruby".

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`lib/rubygems/specification.rb`	Alters `missing_extensions?` logic to return `false` on JRuby.
`lib/rubygems/stub_specification.rb`	Alters stub `missing_extensions?` logic to return `false` on JRuby.
`bundler/lib/bundler/stub_specification.rb`	Alters Bundler stub `missing_extensions?` logic to return `false` on JRuby.
`test/rubygems/test_gem.rb`	Updates warning expectations for `Gem.try_activate` on JRuby.
`test/rubygems/test_gem_stub_specification.rb`	Updates warning expectations and changes what is asserted on JRuby.
`test/rubygems/test_gem_specification.rb`	Updates warning expectations and missing-extensions assertions on JRuby.
`spec/bundler/stub_specification_spec.rb`	Updates Bundler stub specs expectations (but currently introduces a syntax error).

Comments suppressed due to low confidence (1)

bundler/lib/bundler/stub_specification.rb:60

On JRuby, forcing missing_extensions? to false means ignored? will also be false, so Bundler will include gems whose extensions were never built for the current platform/engine (and may later fail at runtime). To address the reported warning spam (including the CRuby+java-platform case), keep missing_extensions? semantics and gate the warning in ignored? on platform compatibility (similar to RubyGems' BasicSpecification#contains_requirable_file?), rather than disabling missing-extension detection entirely on JRuby.

    def missing_extensions?
      return false if RUBY_ENGINE == "jruby"
      return false if default_gem?
      return false if extensions.empty?
      return false if File.exist? gem_build_complete_path
      return false if manually_installed?

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T08:45:45Z

  # probably want to build_extensions

  def missing_extensions?
+    return false if RUBY_ENGINE == "jruby"


missing_extensions? returning false unconditionally on JRuby changes behavior beyond silencing warnings: specs with unbuilt extensions will no longer be marked ignored, so they can be selected for activation/resolution even though their native bits are unavailable for the current platform/ABI (and commands like gem pristine --only-missing-extensions will stop working). Instead of short-circuiting missing_extensions? by engine, keep the missing-extension detection intact and suppress the warning in the caller(s) when the spec is for a different platform (or when running on non-CRuby engines).

Suggested change

return false if RUBY_ENGINE == "jruby"

Copilot · 2026-04-01T08:45:46Z

  end

  def missing_extensions?
+    return false if RUBY_ENGINE == "jruby"


The JRuby early return in missing_extensions? prevents Gem::StubSpecification#ignored? from filtering out specs whose extensions are not built for the current platform, which can lead to incompatible gems being considered activatable under a shared GEM_HOME. This method should continue to report missing extensions based on gem_build_complete_path; if the goal is to avoid noisy output, adjust the warning site(s) instead (e.g., only warn when Gem::Platform.local === platform).

Suggested change

return false if RUBY_ENGINE == "jruby"

Copilot · 2026-04-01T08:45:46Z

    end

-    it "returns true if not manually_installed?" do
+    it "returns #{RUBY_ENGINE == "jruby" ? "false" : "true"} if not manually_installed?" do


This example description string is a syntax error because it uses unescaped double quotes inside a double-quoted string interpolation (RUBY_ENGINE == "jruby" ? ...). Use single quotes inside the interpolation, or build the description string without nested quotes.

Suggested change

it "returns #{RUBY_ENGINE == "jruby" ? "false" : "true"} if not manually_installed?" do

it "returns #{RUBY_ENGINE == 'jruby' ? 'false' : 'true'} if not manually_installed?" do

Copilot · 2026-04-01T08:45:46Z

    stub_with_extension do |stub|
      _, err = capture_output do
-        refute stub.contains_requirable_file? "nonexistent"
+        if RUBY_ENGINE == "jruby"
+          refute stub.ignored?
+        else
+          refute stub.contains_requirable_file? "nonexistent"
+        end


The JRuby branch stops exercising contains_requirable_file? entirely (it only checks ignored?), which weakens coverage of the behavior this test is named after. Prefer asserting refute stub.contains_requirable_file?("nonexistent") on all engines, and only vary the stderr expectation (empty vs warning) to verify the warning-suppression behavior.

Copilot · 2026-04-01T08:45:47Z

+      if RUBY_ENGINE == "jruby"
+        refute @ext.ignored?
+      else
+        refute @ext.contains_requirable_file? "nonexistent"
+      end


Similar to the stub-spec test, the JRuby branch no longer tests contains_requirable_file? and therefore doesn't validate the warning/no-warning behavior at the call site. Consider keeping the contains_requirable_file? assertion for JRuby as well, and only adjust the stderr expectation.

Suggested change

if RUBY_ENGINE == "jruby"

refute @ext.ignored?

else

refute @ext.contains_requirable_file? "nonexistent"

end

refute @ext.contains_requirable_file? "nonexistent"

Copilot · 2026-04-01T08:45:47Z

+    if RUBY_ENGINE == "jruby"
+      assert_equal "", err
+    else
+      expected = "Ignoring ext-1 because its extensions are not built. " \
+                 "Try: gem pristine ext --version 1\n"

-    assert_equal expected, err
+      assert_equal expected, err
+    end


This test now expects no warning on JRuby, but the implementation change achieves that by disabling missing-extension detection entirely on JRuby (which can allow incompatible specs into activation). Once warning suppression is implemented at the warning site, update this test to verify that missing extensions are still detected/ignored while stderr remains quiet, instead of changing missing_extensions? semantics by engine.

Copilot · 2026-04-01T08:45:47Z

+    if RUBY_ENGINE == "jruby"
+      refute stub.missing_extensions?
+    else
+      assert stub.missing_extensions?
+    end


These assertions now make missing_extensions? engine-dependent, but missing_extensions? is also used for correctness (filtering/pristine --only-missing-extensions), not just warnings. If the intent is only to silence warnings under cross-platform shared GEM_HOME, keep missing_extensions? reporting true when the current platform's gem.build_complete is absent and suppress the warning output separately.

Suggested change

if RUBY_ENGINE == "jruby"

refute stub.missing_extensions?

else

assert stub.missing_extensions?

end

assert stub.missing_extensions?

Copilot · 2026-04-01T08:45:47Z

+    if RUBY_ENGINE == "jruby"
+      refute @ext.missing_extensions?
+    else
+      assert @ext.missing_extensions?
+    end


Making missing_extensions? return false on JRuby changes core behavior and this test now codifies that change. If the desired behavior is “still ignore specs missing extensions, but don’t warn when those specs are effectively for another platform/engine”, adjust the warning logic and keep missing_extensions? consistent across engines; then this test should continue to expect @ext.missing_extensions? to be true before build_extensions.

Suggested change

if RUBY_ENGINE == "jruby"

refute @ext.missing_extensions?

else

assert @ext.missing_extensions?

end

assert @ext.missing_extensions?

JRuby does not require extension rebuilds when switching JRuby or Java versions because Java extensions are shipped pre-compiled and JRuby does not expose a version-specific C API. This means missing_extensions? returning true on JRuby is almost always a false positive and the suggested `gem pristine` is not actionable. Return false early from missing_extensions? on JRuby so that all downstream warnings and ignored-spec filtering are suppressed at the source rather than patching each warning site individually. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

When no gems have missing extensions (e.g. on JRuby where missing_extensions? always returns false), display an informational message instead of raising Gem::Exception. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Ignore warnings with spec different platfroms (cherry picked from commit 83ea8b8)

hsbt force-pushed the ignore-spec-different-platfroms branch 4 times, most recently from c316ba9 to c5b7fb4 Compare February 20, 2025 07:33

hsbt marked this pull request as ready for review February 20, 2025 08:16

segiddins reviewed Feb 20, 2025

View reviewed changes

hsbt force-pushed the ignore-spec-different-platfroms branch 4 times, most recently from 743b51b to ea0266e Compare June 12, 2025 08:59

hsbt force-pushed the ignore-spec-different-platfroms branch from ea0266e to 8cca385 Compare June 27, 2025 04:51

hsbt added rubygems: enhancement bundler: enhancement labels Nov 20, 2025

hsbt changed the title ~~Ignore spec different platfroms~~ Ignore warnings with spec different platfroms Jan 26, 2026

hsbt mentioned this pull request Feb 10, 2026

JRuby: tests fail on output assertions about warnings emitted by syslog ruby/cgi#108

Open

hsbt force-pushed the ignore-spec-different-platfroms branch from 7148b2e to 90e7e04 Compare April 1, 2026 08:40

Copilot AI review requested due to automatic review settings April 1, 2026 08:40

Copilot started reviewing on behalf of hsbt April 1, 2026 08:41 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

hsbt force-pushed the ignore-spec-different-platfroms branch 2 times, most recently from dd38baa to 6d73df9 Compare April 1, 2026 09:00

hsbt force-pushed the ignore-spec-different-platfroms branch from 6d73df9 to 9fedee5 Compare April 2, 2026 01:35

hsbt force-pushed the ignore-spec-different-platfroms branch from 9fedee5 to 738d2db Compare April 2, 2026 01:41

hsbt merged commit 83ea8b8 into master Apr 2, 2026
97 checks passed

hsbt deleted the ignore-spec-different-platfroms branch April 2, 2026 02:52

hsbt mentioned this pull request Apr 7, 2026

Prepare RubyGems 4.0.10 and Bundler 4.0.10 #9459

Closed

hsbt added a commit that referenced this pull request Apr 7, 2026

Merge pull request #8508 from ruby/ignore-spec-different-platfroms

18e26fb

Ignore warnings with spec different platfroms (cherry picked from commit 83ea8b8)

hsbt changed the title ~~Ignore warnings with spec different platfroms~~ Ignore warnings with spec different platforms Apr 7, 2026

hsbt mentioned this pull request Apr 7, 2026

Prepare RubyGems 4.0.10 and Bundler 4.0.10 #9461

Merged

hsbt added a commit that referenced this pull request Apr 7, 2026

Merge pull request #8508 from ruby/ignore-spec-different-platfroms

7dcf595

Ignore warnings with spec different platfroms (cherry picked from commit 83ea8b8)

hsbt mentioned this pull request Apr 9, 2026

Extension gems built for JRuby warn when switching Java version #3520

Closed

This was referenced Apr 10, 2026

[ruby-on-rails] Bump Gemfile and Bundler to 4.0.10 hayat01sh1da/botpress-accuracy-checkers#85

Merged

[ruby-on-rails] Bump Gemfile and Bundler to 4.0.10 hayat01sh1da/tutorials#220

Merged

	it "returns #{RUBY_ENGINE == "jruby" ? "false" : "true"} if not manually_installed?" do
	it "returns #{RUBY_ENGINE == 'jruby' ? 'false' : 'true'} if not manually_installed?" do

Uh oh!

Conversation

hsbt commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was the end-user or developer problem that led to this PR?

What is your fix for the problem, implemented in this PR?

TODO

Make sure the following tasks are checked

Uh oh!

deivid-rodriguez commented Feb 19, 2025

Uh oh!

hsbt commented Feb 20, 2025

Uh oh!

deivid-rodriguez commented Feb 20, 2025

Uh oh!

hsbt commented Feb 20, 2025

Uh oh!

deivid-rodriguez commented Feb 20, 2025

Uh oh!

segiddins Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

headius commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I don't think this is the right fix because it will hide all instances of this warning in JRuby

For example, will jruby-launcher extension work on JRuby if installed under non-jruby?

Why is this only limited to jruby?

Uh oh!

headius commented Apr 9, 2025

Uh oh!

headius commented Apr 9, 2025

Uh oh!

hsbt commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hsbt commented Feb 19, 2025 •

edited

Loading

headius commented Apr 9, 2025 •

edited

Loading