Restore rb_sys dependency for Rust#9416
Open
bangseongbeom wants to merge 2 commits intoruby:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the rb_sys gem dependency in Bundler’s Rust gem scaffolding so the generated Rakefile (which requires rb_sys/extensiontask) works after bundle install, fixing LoadError failures when running tasks like bundle exec rake compile.
Changes:
- Add
rb_sysas a dependency in the Rustnewgemgemspec template. - Update
bundle gem --ext=rustspecs to assert the generated gemspec includesrb_sys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
bundler/spec/commands/newgem_spec.rb |
Updates Rust scaffold expectations to include an rb_sys dependency in the generated gemspec. |
bundler/lib/bundler/templates/newgem/newgem.gemspec.tt |
Adds rb_sys dependency when generating a gem with --ext=rust. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
After running
bundle gem --ext=rust my_gemandbundle install, I got an error when I runbundle exec rake compile(I followed oxidize.rb guide):What is your fix for the problem, implemented in this PR?
Revert #8455 partially. In that PR,
rb_syswas removed from the dependencies, but it seems to be unintended. Withoutrb_sys,rb_sys/extensiontaskcannot be loaded, so all rake commands cannot be run.Make sure the following tasks are checked