Implement Capybara::Cuprite::Node#rect#311
Merged
route merged 1 commit intorubycdp:mainfrom Apr 4, 2026
Merged
Conversation
Closes rubycdp#276 The implementation's call to [toJSON][] is necessary since the object returned by [Element.getBoundingClientRect][] is an instance of [DOMRect][], and is therefore unable to have its keys iterated and serialized back to Cuprite on its own. [Element.getBoundingClientRect]: https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect [DOMRect]: https://developer.mozilla.org/en-US/docs/Web/API/DOMRect [toJSON]: segment-boneyard/nightmare#723 (comment)
Member
|
Nice, I was just looking into this. I'll see tomorrow more closely, but looking good! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #276
The implementation's call to toJSON is necessary since the object returned by Element.getBoundingClientRect is an instance of DOMRect, and is therefore unable to have its keys iterated and serialized back to Cuprite on its own.