Add started_at/ended_at datetime fields to Banner#1342
Open
diti0-dot wants to merge 3 commits intorubyforgood:mainfrom
Open
Add started_at/ended_at datetime fields to Banner#1342diti0-dot wants to merge 3 commits intorubyforgood:mainfrom
diti0-dot wants to merge 3 commits intorubyforgood:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216
What is the goal of this PR and why is this important?
Adds support for scheduled banners with start/end dates
How did you approach the change?
Added started_at/ended_at datetime fields to Banner, created an :active scope to filter by current date, and updated display_banner helper to show all active banners instead of just the last one.
UI Testing Checklist
Anything else to add?
Should I also add the started_at and ended_at fields to the banners/new form?