Skip to content

Add submitter confirmation email to WorkshopIdea#1354

Open
maebeale wants to merge 1 commit intomainfrom
maebeale/add-submission-emails
Open

Add submitter confirmation email to WorkshopIdea#1354
maebeale wants to merge 1 commit intomainfrom
maebeale/add-submission-emails

Conversation

@maebeale
Copy link
Collaborator

@maebeale maebeale commented Mar 7, 2026

What is the goal of this PR and why is this important?

  • WorkshopIdea was the only submission model missing a submitter confirmation email
  • All other submission models (StoryIdea, WorkshopVariationIdea, WorkshopLog, EventRegistration) already send both a submitter email and an admin FYI
  • This aligns WorkshopIdea with the established pattern

How did you approach the change?

  • Added idea_submitted notification call in WorkshopIdeasController#create, before the existing idea_submitted_fyi admin notification
  • Uses the same idea_submitted kind already used by StoryIdea and WorkshopVariationIdea — the mailer method and templates already exist
  • Added request spec verifying both notifications are sent on create (matching the pattern in workshop_variation_ideas_spec.rb)

UI Testing Checklist

  • Create a new WorkshopIdea as a regular user — verify submitter receives confirmation email
  • Verify admin still receives FYI notification email
  • Verify email subject reads "AWBW Portal: Your workshop idea has been received"

Anything else to add?

  • No new mailer methods or templates needed — the existing NotificationMailer#idea_submitted handles all idea types polymorphically via model_name.human

🤖 Generated with Claude Code

WorkshopIdea was the only submission model missing a submitter
notification — StoryIdea, WorkshopVariationIdea, WorkshopLog, and
EventRegistration already sent both. This aligns the pattern.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant