Skip to content

Hide Cancel button for Fullfilled requests #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefannibrasil wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −2
Open

Hide Cancel button for Fullfilled requests #5558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
879b4f1
Hide Cancel button on fulfilled requests
stefannibrasil May 4, 2026
38e9eec
Merge branch 'main' into hide-cancel-button-fullfilled-requests-5544
stefannibrasil May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/views/requests/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,10 @@
<%= submit_button_to start_request_path(@request), {text: "Fulfill request", size: "md"} unless @request.distribution %>
<%= view_button_to(distribution_path(@request.distribution), {text: "View Associated Distribution", size: "md"}) if @request.distribution %>
<%= print_button_to print_picklist_request_path(@request), { format: :pdf, text: "Print", size: "md" } %>
<%= button_to 'Cancel', new_request_cancelation_path(request_id: @request.id),
method: :get, data: { disable_with: "Please wait..." }, form_class: 'd-inline', class: 'btn btn-danger btn-md' %>
<% unless @request.status_fulfilled? %>
<%= button_to 'Cancel', new_request_cancelation_path(request_id: @request.id),
method: :get, data: { disable_with: "Please wait..." }, form_class: 'd-inline', class: 'btn btn-danger btn-md' %>
<% end %>
</div>
</div>
</div>
Expand Down
13 changes: 13 additions & 0 deletions spec/requests/requests_requests_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,19 @@
expect(response.body).not_to include('Units (if applicable)')
end
end

context 'when the request has a Fulfilled status' do
it 'does not display the Cancel button' do
fulfilled_request = create(:request, :fulfilled)

get requests_path(fulfilled_request)

page = Nokogiri::HTML(response.body)
cancel_button = page.at_css('button') { |el| el.text.strip == 'Cancel' }

expect(cancel_button).not_to be_present
end
end
end

describe 'POST #start' do
Expand Down
Loading