docs: remove duplicate info froms README, remove flash run from instructions#43
Open
muhsinking wants to merge 3 commits intomainfrom
Open
docs: remove duplicate info froms README, remove flash run from instructions#43muhsinking wants to merge 3 commits intomainfrom
muhsinking wants to merge 3 commits intomainfrom
Conversation
muhsinking
changed the title
KAJdev
requested changes
Mar 11, 2026
Contributor
KAJdev
left a comment
KAJdev
left a comment
There was a problem hiding this comment.
Okay, I got halfway through using individual comments, but the underlying theme is that there's a mismatch of python script.py and uv run script.py. We should prefer uv run in all cases.
That's the main thing I found. everything else looks okay.
| # run with: flash run | ||
| # test directly: python gpu_worker.py | ||
| # GPU serverless worker -- detects available GPU hardware. | ||
| # Run: python gpu_worker.py |
|
|
||
| ```bash | ||
| uv run flash run | ||
| python gpu_worker.py |
| ### Test Worker Locally | ||
| ### Run the Worker | ||
| ```bash | ||
| python gpu_worker.py |
| # run with: flash run | ||
| # test directly: python cpu_worker.py | ||
| # CPU serverless worker -- lightweight processing without GPU. | ||
| # Run: python cpu_worker.py |
|
|
||
| ```bash | ||
| uv run flash run | ||
| python cpu_worker.py |
| # run with: flash run | ||
| # test directly: python cpu_lb.py | ||
| # CPU load-balanced endpoints with custom HTTP routes. | ||
| # Run: python cpu_lb.py (test worker setup) |
| # run with: flash run | ||
| # test directly: python gpu_lb.py | ||
| # GPU load-balanced endpoints with custom HTTP routes. | ||
| # Run: python gpu_lb.py (test worker setup) |
Comment on lines
+46
to
+49
| python gpu_lb.py | ||
|
|
||
| # Test CPU load-balanced worker | ||
| python cpu_lb.py |
| # run with: flash run | ||
| # test directly: python cpu_worker.py | ||
| # CPU autoscaling strategies -- scale-to-zero and burst-ready. | ||
| # Run: python cpu_worker.py |
| # run with: flash run | ||
| # test directly: python gpu_worker.py | ||
| # GPU autoscaling strategies -- scale-to-zero, always-on, high-throughput. | ||
| # Run: python gpu_worker.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users in the UX study reported that it was unnecessary/confusing to have the conceptual information repeated in the flash examples readme.
Also restructured it to put "what is flash" after the getting started steps.