Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
rowanno-std + liballoc compatible.Currently, it also inlines the
countmeandtext_sizecrates into respective modules undersrc, as they are alsostd-bound when they don't need to be. Those can be removed once those modules are made no-std compatible.I'm opening this since it is easy to do so, but given the current maintenance status, I'm not expecting that it is likely to be merged - that said, just ping me if you want any changes, and I'm happy to make them, or to rebase this on a newer branch if needed.
I plan to publish a fork of this crate containing these changes to unblock my own use case, but would like to stick with mainline if possible, so if this does get merged (or the rewrite is no-std + liballoc compatible), I'll retire that.