docs(ch00): remove duplicated sentence in chapter 0 introduction#4676
Open
MoustaphaCamara wants to merge 1 commit intorust-lang:mainfrom
Open
docs(ch00): remove duplicated sentence in chapter 0 introduction#4676MoustaphaCamara wants to merge 1 commit intorust-lang:mainfrom
MoustaphaCamara wants to merge 1 commit intorust-lang:mainfrom
Conversation
The sentence was already present at line 183.
|
I took a look at the file's commit history, and I've noticed that the line you removed is actually "the original", with the sentence above the table being added in 112ceae. |
Author
|
I see your point. As I mentioned, I felt the newer version was more complete and better placed, which is why I suggested removing the one under the table instead. Maybe this could be a good in-between? Keeping original sentence below the table, and keeping Ferris mention above. diff --git a/src/ch00-00-introduction.md b/src/ch00-00-introduction.md
index 31e9823a..d5636731 100644
--- a/src/ch00-00-introduction.md
+++ b/src/ch00-00-introduction.md
@@ -180,9 +180,7 @@ As such, we’ll provide many examples that don’t compile along with the error
message the compiler will show you in each situation. Know that if you enter
and run a random example, it may not compile! Make sure you read the
surrounding text to see whether the example you’re trying to run is meant to
-error. In most situations, we’ll lead you to the correct version of any code
-that doesn’t compile. Ferris will also help you distinguish code that isn’t
-meant to work:
+error. Ferris will also help you distinguish code that isn’t meant to work:
| Ferris | Meaning |
| ---------------------------------------------------------------------------------------------------------------- | ------------------------------------------------ |
@@ -190,6 +188,9 @@ meant to work:
| <img src="img/ferris/panics.svg" class="ferris-explain" alt="Ferris throwing up their hands"/> | This code panics! |
| <img src="img/ferris/not_desired_behavior.svg" class="ferris-explain" alt="Ferris with one claw up, shrugging"/> | This code does not produce the desired behavior. |
+In most situations, we’ll lead you to the correct version of any code
+that doesn’t compile.
+
## Source Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentence was already present at line 183.
I kept the version introduced most recently (per
git blame), which includes the mention of Ferris.