-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs(report): enhance man pages for cargo report *
#16430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
They were missing before
e08f161 to
eb13e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are sub-sub command man pages normally named and handled?
Do we need to update --help to call this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-container-run
DOCKER(1) Docker User Manuals DOCKER(1)
NAME
docker-container-run - Create and run a new container from an image
SYNOPSIS
docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]
DESCRIPTION
Alias for docker run.
OPTIONS
--add-host= Add a custom host-to-IP mapping (host:ip)
--annotation=map[] Add an annotation to the container (passed through to
the OCI runtime)
-a, --attach= Attach to STDIN, STDOUT or STDERR
podman-machine-start
https://docs.podman.io/en/latest/markdown/podman-machine-start.1.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update --help to call this out?
Yes, but cargo help hasn't yet supported it, and I am not sure whether cargo help report-timings makes more sense or cargo help report timings (mind the dash).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, adding the support to cargo help for sub-sub commands may need FCP. This PR doesn't I think, at least it still provides the HTML docs
Except in diagnostics, we use `future-incompat` the alias more often, and it is also easier to type correctly. Make it the primary name than an alias
eb13e52 to
d34d267
Compare
What does this PR try to resolve?
Make space for future report kinds iun
cargo reportdocumentations.cargo reportman page didn't match its--helptext equivalentreport future-incompatthe primary name instead of an alias.cargo report future-incompatdidn't have its own man page.Note that
cargo helphasn't yet supported forfuture-incompat.It will be a separate PR.
How to test and review this PR?