refactor: drop yanked_whitelist from source loading#17014
Conversation
Most call sites constructed with an empty allowlist, and `PackageRegistry::load` was the only place that passed a real list so we do a post construction after PackageRegistry construction in `load`. The parameter was only load-bearing for `PackageRegistry`.
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
On its own, this is likely fine and I would be fine reviewing and merging if you want but I wonder if we should go in a different direction for the motivating case behind this. I worry about the complexity that has grown around yanked as we have added features around it, like One half-developed idea is that |
What does this PR try to resolve?
Split off from #17012 for an easier review experience I guess.
Most call sites constructed with an empty allowlist,
and
PackageRegistry::loadwas the only place that passed a real listso we do a post construction after
PackageRegistryinload.The parameter was only load-bearing for
PackageRegistry.How to test and review this PR?
This has no user-facing behavior change.