Preserve explicit lifetime information when removing mut
#16273
Conversation
Rather than trying to reconstruct the reference type without the `mut`, remove the `mut` itself so that user-inserted lifetime information is preserved. The message has been changed from "consider changing to [NON-MUT REF]" to "remove this `mut`"
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for dcb19a0
This comment will be updated if you push new changes |
| sp, | ||
| "consider changing to".to_string(), | ||
| format!("&{}", snippet(cx, cx.tcx.hir_span(inner_ty.ty.hir_id), "_"),), | ||
| mut_span, |
There was a problem hiding this comment.
Is there any reason not to use this as the lint span?
There was a problem hiding this comment.
Given the existing message ("this argument is a mutable reference, but not used mutably") it makes sense to point to the whole argument when linting.
I'll change this to "this parameter is a mutable reference but is not used mutably" which is more correct though.
Tell me if you want me to change the span.
There was a problem hiding this comment.
I'm fine with not dealing with this now. I have a general issue with how we use error spans that are way larger than what's needed to communicate the problem, but it's also unrelated to fixing the suggestion.
rustbot
removed
the
S-waiting-on-review
3 participants
Rather than trying to reconstruct the reference type without the
mut, remove themutitself so that user-inserted lifetime information is preserved.The message has been changed from "consider changing to [NON-MUT REF]" to "remove this
mut"changelog: [
needless_pass_by_ref_mut]: preserve user-provided lifetime informationFixes #16267