Skip to content

Remove use of const traits (and feature(effects)) from stdlib #126552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 4 commits into from
Jun 22, 2024
Merged

Remove use of const traits (and feature(effects)) from stdlib #126552

bors merged 4 commits into from
Jun 22, 2024

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jun 16, 2024 •
edited
Loading

The current uses are already unsound because they are using non-const impls in const contexts. We can reintroduce them by reverting the commit in this PR, after #120639 lands.

Also, make effects an incomplete feature.

cc @rust-lang/project-const-traits
r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 16, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Jun 16, 2024 •
edited
Loading

r=me when ci is green

Note for anyone whose nightly code has regressed because we removed const traits from libstd

Please pin your nightly version to 2024-06-16 since it's likely going to be a bit of time before we restore const to some of these traits like PartialEq and Add. Sorry!

@fee1-dead fee1-dead mentioned this pull request Jun 16, 2024
Closed
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Jun 16, 2024

Could also mark the features as incomplete now as then they won't be usable in libcore accidentally

@compiler-errors
Copy link
Member

compiler-errors commented Jun 16, 2024

Yeah, good idea. Will require adding a bunch of //~^ WARN the feature effects is incomplete to the test suite, but I'd rather mark it incomplete until we're confident about it!

@compiler-errors
Copy link
Member

compiler-errors commented Jun 18, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2024
@bors
Copy link
Collaborator

bors commented Jun 20, 2024

☔ The latest upstream changes (presumably #116088) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jun 21, 2024
@fee1-dead
Copy link
Member Author

fee1-dead commented Jun 21, 2024 •
edited
Loading

I made effects incomplete and blessed the ui tests.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

compiler-errors commented Jun 21, 2024

r=me after making tests pass

@compiler-errors
Copy link
Member

compiler-errors commented Jun 21, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2024
@fee1-dead
Copy link
Member Author

fee1-dead commented Jun 22, 2024

@bors r=compiler-errors

@oli-obk
Copy link
Contributor

oli-obk commented Jun 22, 2024

Looks like the book uses effects in examples

@fee1-dead
Copy link
Member Author

fee1-dead commented Jun 22, 2024

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 22, 2024

📌 Commit 81da6a6 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 22, 2024
Merged
@bors bors merged commit dc9a08f into rust-lang:master Jun 22, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 22, 2024
@bors
Copy link
Collaborator

bors commented Jun 22, 2024

⌛ Testing commit 81da6a6 with merge a0f01c3...

@W95Psp W95Psp mentioned this pull request Jun 24, 2024
Merged
@brunocodutra brunocodutra mentioned this pull request Jun 29, 2024
Merged
@fee1-dead fee1-dead deleted the rmfx branch June 30, 2024 16:33
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jun 30, 2024
Closed
@fee1-dead fee1-dead added the PG-const-traits Project group: Const traits label Aug 9, 2024
@fee1-dead fee1-dead mentioned this pull request Aug 25, 2024
Closed
14 tasks
@RalfJung RalfJung mentioned this pull request Aug 25, 2024
Merged
@compiler-errors compiler-errors mentioned this pull request Oct 28, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 10, 2024
Closed
@fee1-dead fee1-dead added the F-const_trait_impl `#![feature(const_trait_impl)]` label Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels

F-const_trait_impl `#![feature(const_trait_impl)]` PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

6 participants

@fee1-dead @compiler-errors @rust-log-analyzer @oli-obk @bors @rustbot