Unconstrained parameter fix by TomtheCoder2 · Pull Request #148788 · rust-lang/rust

TomtheCoder2 · 2025-11-10T14:17:59Z

This PR is an attempt to solve the issue described in the issue #107295

rustbot · 2025-11-10T14:18:03Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

rustbot · 2025-11-10T14:18:06Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rust-bors · 2026-01-13T00:02:13Z

☔ The latest upstream changes (presumably #150844) made this pull request unmergeable. Please resolve the merge conflicts.

When an unconstrained type or lifetime parameter is detected in an `impl`, provide more specific help based on its usage: - If the parameter is entirely unused, suggest removing it. - If it is used in the `impl` body but not the `Self` type, suggest including it in the `Self` type and the struct definition. This also adds a comprehensive UI test for these cases.

rustbot · 2026-05-09T05:52:02Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

davidtwco · 2026-05-15T12:53:05Z

@bors r+

rust-bors · 2026-05-15T12:53:08Z

📌 Commit d02b4c8 has been approved by davidtwco

It is now in the queue for this repository.

…avidtwco Unconstrained parameter fix This PR is an attempt to solve the issue described in the issue #107295

…er-fix, r=davidtwco Unconstrained parameter fix This PR is an attempt to solve the issue described in the issue rust-lang#107295

Zalathar · 2026-05-15T14:14:02Z

@bors yield (enclosing rollup)

rust-bors · 2026-05-15T14:14:06Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/25921708313

The next pull request likely to be tested is #156610.

Rollup of 11 pull requests Successful merges: - #148788 (Unconstrained parameter fix) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #155521 (Add lint againts invalid runtime symbol definitions) - #156319 (Require EIIs to be defined when we compile a rust dylib) - #156452 (Implement pinned drop sugar) - #156600 (Make const param default test reproduce original ICE) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion)

…avidtwco Unconstrained parameter fix This PR is an attempt to solve the issue described in the issue #107295

rust-log-analyzer · 2026-05-15T16:31:06Z

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test expr_store::tests::body::async_fn_weird_param_patterns ... ok
test expr_store::scope::tests::test_shadow_variable ... ok
test expr_store::scope::tests::while_let_adds_binding ... ok
test expr_store::tests::body::array_element_cfg ... ok
error: test failed, to rerun pass `-p hir-def --lib`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/hir_def-f381e8bd2208ec8b '--skip=tests::smoke_test_real_sysroot_cargo' --skip=check_code_formatting -Z unstable-options --format json` (signal: 11, SIGSEGV: invalid memory reference)
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 1:04:45
  local time: Fri May 15 16:30:50 UTC 2026
  network time: Fri, 15 May 2026 16:30:50 GMT
##[error]Process completed with exit code 1.

rust-bors · 2026-05-15T16:31:59Z

💔 Test for 7e9c9ef failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-05-15T16:33:41Z

@bors retry

…uwer Rollup of 12 pull requests Successful merges: - #148788 (Unconstrained parameter fix) - #156319 (Require EIIs to be defined when we compile a rust dylib) - #156452 (Implement pinned drop sugar) - #156554 (Allow user-provided `llvm_args` to override target spec arguments) - #156571 (Disable `main_needs_argc_argv` for Wasm) - #156600 (Make const param default test reproduce original ICE) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion) - #156604 (coverage: Reduce and clarify the context-mismatch test case)

Rollup merge of #148788 - TomtheCoder2:unconstrained-parameter-fix, r=davidtwco Unconstrained parameter fix This PR is an attempt to solve the issue described in the issue #107295

rustbot assigned davidtwco Nov 10, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 10, 2025