Skip to content

Remove driver_lint_caps#152852

Open
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:remove_driver_lint_caps
Open

Remove driver_lint_caps#152852
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:remove_driver_lint_caps

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented Feb 19, 2026

View all comments

It was only used by rustdoc and doesn't seem like it was necessary there. No tests fail at least.

r? rust-lang/rustdoc

@bjorn3 bjorn3 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 19, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 19, 2026

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2026
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the remove_driver_lint_caps branch from d66dd3d to 2aa9c6c Compare February 19, 2026 14:01
@rust-bors

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the remove_driver_lint_caps branch from 2aa9c6c to baef897 Compare February 21, 2026 11:52
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the remove_driver_lint_caps branch from baef897 to 031197e Compare May 15, 2026 10:19
@rustbot

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the remove_driver_lint_caps branch from 031197e to 3934a20 Compare May 15, 2026 10:21
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

It was only used by rustdoc and doesn't seem like it was necessary
there. No tests fail at least.
@bjorn3 bjorn3 force-pushed the remove_driver_lint_caps branch from 3934a20 to 379caad Compare May 15, 2026 13:42
@notriddle
Copy link
Copy Markdown
Contributor

notriddle commented May 15, 2026

I wrote a couple of tests for this functionality while reviewing it. I didn't find any problems, but I'd like to put together more test cases for this functionality, too.

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 15, 2026

📌 Commit 379caad has been approved by notriddle

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 16, 2026
Remove driver_lint_caps

It was only used by rustdoc and doesn't seem like it was necessary there. No tests fail at least.

r? rust-lang/rustdoc
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 16, 2026

💔 Test for 7bb6818 failed: CI. Failed job:

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#13 DONE 23.8s

#14 [ 6/25] RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.189 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
#14 0.206 Executing: /tmp/apt-key-gpghome.VqEMJSqQnC/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 1.786 gpg: key 74DA7924C5513486: public key "Igor Kozhukhov <igor@dilos.org>" imported
#14 1.790 gpg: Total number processed: 1
#14 1.790 gpg:               imported: 1
#14 DONE 1.9s

@notriddle
Copy link
Copy Markdown
Contributor

Nothing in this change seems like it would cause installing /tmp/build-x86_64-fortanix-unknown-sgx-toolchain.sh to fail.

@bors retry

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 16, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 16, 2026
Remove driver_lint_caps

It was only used by rustdoc and doesn't seem like it was necessary there. No tests fail at least.

r? rust-lang/rustdoc
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 16, 2026

💔 Test for 749f898 failed: CI. Failed job:

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#13 DONE 27.1s

#14 [ 6/25] RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.165 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
#14 0.182 Executing: /tmp/apt-key-gpghome.usBREKKOg7/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.940 gpg: key 74DA7924C5513486: public key "Igor Kozhukhov <igor@dilos.org>" imported
#14 0.946 gpg: Total number processed: 1
#14 0.946 gpg:               imported: 1
#14 DONE 1.0s

@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented May 16, 2026

@bors retry

Spurious failure fixed by #156640.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 16, 2026
…notriddle

Remove driver_lint_caps

It was only used by rustdoc and doesn't seem like it was necessary there. No tests fail at least.

r? rust-lang/rustdoc
rust-bors Bot pushed a commit that referenced this pull request May 16, 2026
Rollup of 6 pull requests

Successful merges:

 - #152852 (Remove driver_lint_caps)
 - #156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found)
 - #156518 ([style] rustfmt `match`es with comments in or-patterns)
 - #156596 (Split `LintExpectationId`s)
 - #156577 (Test EII UI tests with prefer-dynamic)
 - #156633 (Add regression test for issue #41261)
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 17, 2026
Remove driver_lint_caps

It was only used by rustdoc and doesn't seem like it was necessary there. No tests fail at least.

r? rust-lang/rustdoc
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 17, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 17, 2026

💔 Test for fd90000 failed: CI. Failed jobs:

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
Image input checksum 3bb6189c7ea1e98a8d56c1271318ec97a9baff7314c7ee19883a797f004221cdb888aee3db0d141238657b2b9cd4ae51bcd1ab4ac94023cb6fe33af67c8202e2
##[group]Building docker image for dist-x86_64-linux
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants