ci: Add dist-aarch64-freebsd#154265
Conversation
rustbot
added
A-CI
|
r? @marcoieni rustbot has assigned @marcoieni. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
This is awesome, @mrkajetanp . And I for one would support raising the minimum supported version to FreeBSD 13. |
|
you can add files to our mirrors at https://github.com/rust-lang/ci-mirrors |
Ah good to know, thanks! |
mrkajetanp
force-pushed
the
freebsd-aarch64-ci
branch
from
a90679f to
62660fd
Compare
Add scripts to build the aarch64-unknown-freebsd target in CI. Implements MCP: rust-lang/compiler-team#961
mrkajetanp
force-pushed
the
freebsd-aarch64-ci
branch
from
62660fd to
8b6b8f0
Compare
|
Would love to see this merged soon. Great that you're working on it! |
| @@ -5,8 +5,19 @@ set -eux | |||
|
|
|||
| arch=$1 | |||
| binutils_version=2.40 | |||
| freebsd_version=12.3 | |||
| triple=$arch-unknown-freebsd12 | |||
| # FIXME: Use the same version from FreeBSD 14 | |||
There was a problem hiding this comment.
I lost the notifications and I'm only reviewing this PR now. Do you want to fix this before merging?
There was a problem hiding this comment.
Ah good to know! I've been meaning to update this since FreeBSD 13 is now EOL as of this month, so this should just be using FreeBSD 14 across the board. I'll push the update tomorrow.
|
shouldn't we also add a job in https://github.com/rust-lang/rust/blob/main/src/ci/github-actions/jobs.yml ? Otherwise this will never get triggered in CI, right? 🤔 |
| @@ -0,0 +1,44 @@ | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
can we use a more recent ubuntu? Or do we need ubuntu 22 for some reason?
There was a problem hiding this comment.
I'm pretty sure it could be any ubuntu, shouldn't matter that much. I can give it a try with whichever version you think is most appropriate.
There was a problem hiding this comment.
I would prefer the latest lts: 26.04. But 24.04 works as well!
|
I think the clean way is probably to first do a version bump to FreeBSD 14 for existing platforms, then rebase this and make it just a clean addition of aarch64 without messing with the versions. Hence the PR linked above. |
6 participants
Add scripts to build the aarch64-unknown-freebsd target in CI.
Implements MCP: rust-lang/compiler-team#961
There is currently the issue of FreeBSD version support. See the following thread for more details:
#132228
The current version supported by rust is FreeBSD 12, which is already EOL. This means it is no longer possible to download FreeBSD releases from their servers. The aarch64 build is not mirrored on the Rust servers, which is why I couldn't match the version used by already existing CI scripts and had to change this one to FreeBSD 13. FreeBSD 13 itself will be EOL a month from now, on April 30th. We might want to put aarch64 FreeBSD builds on the Rust mirror and update the support across the board to FreeBSD 14 prior to merging this.