Skip to content

Do not index past end of buffer when checking heuristic in error index syntax highlighter #156344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
May 14, 2026
+11 −1
Merged

Do not index past end of buffer when checking heuristic in error index syntax highlighter #156344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_driver_impl/src/highlighter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ impl Highlighter {
// This heuristic test is to detect if the identifier is
// a function call. If it is, then the function identifier is
// colored differently.
if code[*len_accum..*len_accum + len + 1].ends_with('(') {
if code[*len_accum + len..].starts_with('(') {
style = style.fg_color(Some(Color::Ansi(FUNCTION_COLOR)));
}
// The `derive` keyword is colored differently.
Expand Down
3 changes: 3 additions & 0 deletions tests/ui/explain/explanation-code-rendering-edge-case-regression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
//@ compile-flags: --explain E0602 --color always --error-format=human
//@ check-pass
// Ensure that we trigger the condition for #156326 without ICEing.
7 changes: 7 additions & 0 deletions tests/ui/explain/explanation-code-rendering-edge-case-regression.stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
An unknown or invalid lint was used on the command line.

Erroneous code example:

rustc -D bogus rust_file.rs

Maybe you just misspelled the lint name or the lint doesn't exist anymore. Either way, try to update/remove it in order to fix the error.
Loading