Rollup of 2 pull requests#156561
Merged
Merged
Conversation
The compiletest `--pass` flag only affects tests with a `*-pass` directive, i.e. `check-pass`, `build-pass`, or `run-pass`. It has no effect in `*-fail` tests, or in auxiliary crates.
By convention, compiletest directives starting with `ignore-*` normally cause the test itself to be skipped under certain conditions. The `//@ ignore-pass` directive was the only exception to that convention. The new name should hopefully do a better job of communicating its effect, which is to cause the `--pass` flag to not override the test's `build-pass` or `run-pass` directive. The `//@ no-pass-override` directive is mainly useful for tests that expect warnings produced during codegen.
compiletest: Enforce that directives are consistently used with or without a colon With the notable exception of `//@ pp-exact`, all directives expect to either always be used *with* a colon, or always be used *without* a colon. For example: - `//@ uses-colon: value` - `//@ no-colon` or `//@ no-colon (remark)` Currently we just silently discard directives that use the wrong syntax, which is not great. This PR therefore makes `parse_name_directive` and `parse_name_value_directive` panic if the wrong syntax is encountered. The parser for `pp-exact` has been adjusted to check for the colon before deciding which parse method to call. r? jieyouxu
compiletest: Rename `//@ ignore-pass` to `//@ no-pass-override` By convention, compiletest directives starting with `ignore-*` normally cause the test itself to be skipped under certain conditions. The `//@ ignore-pass` directive was the only exception to that convention. The new name should hopefully do a better job of communicating its effect, which is to cause the `--pass` flag to not override the test's `build-pass` or `run-pass` directive. The `//@ no-pass-override` directive is mainly useful for tests that expect warnings produced during codegen. --- r? jieyouxu
rustbot
added
A-compiletest
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: c85af1c5ed In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c85af1c (parent) -> 1a70f8d (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1a70f8d36e818b45829a5c065fd6004c9047e8d1 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (1a70f8d): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.3%, secondary 3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.4%, secondary 10.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 515.921s -> 512.682s (-0.63%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
//@ ignore-passto//@ no-pass-override#156531 (compiletest: Rename//@ ignore-passto//@ no-pass-override)r? @ghost
Create a similar rollup